Re: [PATCH] nbd: server: Report holes for raw images

2021-03-04 Thread Kevin Wolf
Am 25.02.2021 um 19:50 hat Vladimir Sementsov-Ogievskiy geschrieben: > 19.02.2021 19:58, Eric Blake wrote: > > On 2/19/21 10:42 AM, Eric Blake wrote: > > > > > > To me, data=false looks compatible with NBD_STATE_HOLE. From user point > > > > of view, getting same results from qemu-nbd and qemu-img

Re: [PATCH] nbd: server: Report holes for raw images

2021-03-03 Thread Eric Blake
On 3/3/21 3:45 PM, Nir Soffer wrote: I'll wait a few days for any other reviewer commentary before taking this through my NBD tree. >> >> And thanks for CCing me. Hmm, maybe, I'll suggest myself as co-maintainer >> for NBD? Vladimir, I'd be happy if you want to do that in a s

Re: [PATCH] nbd: server: Report holes for raw images

2021-03-03 Thread Nir Soffer
On Thu, Feb 25, 2021 at 8:51 PM Vladimir Sementsov-Ogievskiy < vsement...@virtuozzo.com> wrote: > 19.02.2021 19:58, Eric Blake wrote: > > On 2/19/21 10:42 AM, Eric Blake wrote: > > > >>> To me, data=false looks compatible with NBD_STATE_HOLE. From user point > >>> of view, getting same results fro

Re: [PATCH] nbd: server: Report holes for raw images

2021-02-25 Thread Vladimir Sementsov-Ogievskiy
19.02.2021 19:58, Eric Blake wrote: On 2/19/21 10:42 AM, Eric Blake wrote: To me, data=false looks compatible with NBD_STATE_HOLE. From user point of view, getting same results from qemu-nbd and qemu-img is more important than being more correct about allocation status. More to the point, her

Re: [PATCH] nbd: server: Report holes for raw images

2021-02-25 Thread Vladimir Sementsov-Ogievskiy
19.02.2021 19:07, Nir Soffer wrote: When querying image extents for raw image, qemu-nbd reports holes as zero: $ qemu-nbd -t -r -f raw empty-6g.raw $ qemu-img map --output json nbd://localhost [{ "start": 0, "length": 6442450944, "depth": 0, "zero": true, "data": true, "offset": 0}] $ qemu-im

Re: [PATCH] nbd: server: Report holes for raw images

2021-02-19 Thread Eric Blake
On 2/19/21 10:42 AM, Eric Blake wrote: >> To me, data=false looks compatible with NBD_STATE_HOLE. From user point >> of view, getting same results from qemu-nbd and qemu-img is more >> important than being more correct about allocation status. > > More to the point, here is our inconsistency: >

Re: [PATCH] nbd: server: Report holes for raw images

2021-02-19 Thread Eric Blake
On 2/19/21 10:07 AM, Nir Soffer wrote: > When querying image extents for raw image, qemu-nbd reports holes as > zero: > > $ qemu-nbd -t -r -f raw empty-6g.raw > > $ qemu-img map --output json nbd://localhost > [{ "start": 0, "length": 6442450944, "depth": 0, "zero": true, "data": true, > "offset

[PATCH] nbd: server: Report holes for raw images

2021-02-19 Thread Nir Soffer
When querying image extents for raw image, qemu-nbd reports holes as zero: $ qemu-nbd -t -r -f raw empty-6g.raw $ qemu-img map --output json nbd://localhost [{ "start": 0, "length": 6442450944, "depth": 0, "zero": true, "data": true, "offset": 0}] $ qemu-img map --output json empty-6g.raw [{ "s