Re: [PATCH] vmbus: Don't make QOM property registration conditional

2021-04-27 Thread Eduardo Habkost
On Sun, Apr 25, 2021 at 02:21:38PM +0200, Maciej S. Szmigiero wrote: > On 11.10.2020 01:30, Maciej S. Szmigiero wrote: > > On 09.10.2020 23:33, Eduardo Habkost wrote: > > > On Fri, Oct 09, 2020 at 11:05:47PM +0200, Maciej S. Szmigiero wrote: > > > > On 09.10.2020 22:07, Eduardo Habkost wrote: > > >

Re: [PATCH] vmbus: Don't make QOM property registration conditional

2021-04-25 Thread Maciej S. Szmigiero
On 11.10.2020 01:30, Maciej S. Szmigiero wrote: On 09.10.2020 23:33, Eduardo Habkost wrote: On Fri, Oct 09, 2020 at 11:05:47PM +0200, Maciej S. Szmigiero wrote: On 09.10.2020 22:07, Eduardo Habkost wrote: Having properties registered conditionally makes QOM type introspection difficult. Inste

Re: [PATCH] vmbus: Don't make QOM property registration conditional

2020-10-10 Thread Maciej S. Szmigiero
On 09.10.2020 23:33, Eduardo Habkost wrote: > On Fri, Oct 09, 2020 at 11:05:47PM +0200, Maciej S. Szmigiero wrote: >> On 09.10.2020 22:07, Eduardo Habkost wrote: >>> Having properties registered conditionally makes QOM type >>> introspection difficult. Instead of skipping registration of the >>> "

Re: [PATCH] vmbus: Don't make QOM property registration conditional

2020-10-09 Thread Maciej S. Szmigiero
On 09.10.2020 22:07, Eduardo Habkost wrote: > Having properties registered conditionally makes QOM type > introspection difficult. Instead of skipping registration of the > "instanceid" property, always register the property but validate > its value against the instance id required by the class. >

Re: [PATCH] vmbus: Don't make QOM property registration conditional

2020-10-09 Thread Eduardo Habkost
On Fri, Oct 09, 2020 at 11:05:47PM +0200, Maciej S. Szmigiero wrote: > On 09.10.2020 22:07, Eduardo Habkost wrote: > > Having properties registered conditionally makes QOM type > > introspection difficult. Instead of skipping registration of the > > "instanceid" property, always register the prope

[PATCH] vmbus: Don't make QOM property registration conditional

2020-10-09 Thread Eduardo Habkost
Having properties registered conditionally makes QOM type introspection difficult. Instead of skipping registration of the "instanceid" property, always register the property but validate its value against the instance id required by the class. Signed-off-by: Eduardo Habkost --- Note: due to the