Re: [PATCH 0/5] include/hw/pci include/hw/cxl: Clean up includes

2022-12-21 Thread Markus Armbruster
"Michael S. Tsirkin" writes: > On Fri, Dec 09, 2022 at 02:47:57PM +0100, Markus Armbruster wrote: >> Back in 2016, we discussed[1] rules for headers, and these were >> generally liked: >> >> 1. Have a carefully curated header that's included everywhere first. We >>got that already thanks to

Re: [PATCH 0/5] include/hw/pci include/hw/cxl: Clean up includes

2022-12-21 Thread Michael S. Tsirkin
On Fri, Dec 09, 2022 at 02:47:57PM +0100, Markus Armbruster wrote: > Back in 2016, we discussed[1] rules for headers, and these were > generally liked: > > 1. Have a carefully curated header that's included everywhere first. We >got that already thanks to Peter: osdep.h. > > 2. Headers shoul

[PATCH 0/5] include/hw/pci include/hw/cxl: Clean up includes

2022-12-09 Thread Markus Armbruster
Back in 2016, we discussed[1] rules for headers, and these were generally liked: 1. Have a carefully curated header that's included everywhere first. We got that already thanks to Peter: osdep.h. 2. Headers should normally include everything they need beyond osdep.h. If exceptions are need