Peter Xu writes:
> On Tue, Oct 01, 2024 at 03:25:14PM +0100, Daniel P. Berrangé wrote:
>> On Tue, Oct 01, 2024 at 07:46:09AM +0200, Markus Armbruster wrote:
>> > Command query-migrationthreads went in without a QAPI ACK. Issues
>> > review should have caught:
>> >
>> > * Flawed documentation.
On Tue, Oct 01, 2024 at 03:25:14PM +0100, Daniel P. Berrangé wrote:
> On Tue, Oct 01, 2024 at 07:46:09AM +0200, Markus Armbruster wrote:
> > Command query-migrationthreads went in without a QAPI ACK. Issues
> > review should have caught:
> >
> > * Flawed documentation. Fixed in commit e6c60bf02d
On Tue, Oct 01, 2024 at 07:46:09AM +0200, Markus Armbruster wrote:
> Command query-migrationthreads went in without a QAPI ACK. Issues
> review should have caught:
>
> * Flawed documentation. Fixed in commit e6c60bf02d1.
>
> * It should have been spelled query-migration-threads. Not worth fixi
Command query-migrationthreads went in without a QAPI ACK. Issues
review should have caught:
* Flawed documentation. Fixed in commit e6c60bf02d1.
* It should have been spelled query-migration-threads. Not worth fixing
now, I guess.
* What are the use cases? The commit message doesn't tell!
Prasad reported a misalignment issue with query-migrationthreads v.s. the
recently migration thread name changes. So I prepared patch 1, which will
make the main thread on src be named the same way reported either in
pthread or QMP query-migrationthreads API.
Then I found quite something missing
