Re: [PATCH 00/11] sockets: Attempt to drain the abstract socket swamp

2020-11-02 Thread Markus Armbruster
Daniel P. Berrangé writes: > On Mon, Nov 02, 2020 at 10:59:43AM +0100, Markus Armbruster wrote: >> Daniel P. Berrangé writes: >> >> > On Mon, Nov 02, 2020 at 09:44:49AM +0100, Markus Armbruster wrote: >> >> Daniel P. Berrangé writes: >> >> >> >> > On Fri, Oct 30, 2020 at 11:11:19AM +0100, Mar

Re: [PATCH 00/11] sockets: Attempt to drain the abstract socket swamp

2020-11-02 Thread Markus Armbruster
Daniel P. Berrangé writes: > On Mon, Nov 02, 2020 at 09:44:49AM +0100, Markus Armbruster wrote: >> Daniel P. Berrangé writes: >> >> > On Fri, Oct 30, 2020 at 11:11:19AM +0100, Markus Armbruster wrote: >> >> Marc-André Lureau writes: >> >> >> >> > Hi Markus, >> >> > >> >> > On Thu, Oct 29, 202

Re: [PATCH 00/11] sockets: Attempt to drain the abstract socket swamp

2020-11-02 Thread Daniel P . Berrangé
On Mon, Nov 02, 2020 at 10:59:43AM +0100, Markus Armbruster wrote: > Daniel P. Berrangé writes: > > > On Mon, Nov 02, 2020 at 09:44:49AM +0100, Markus Armbruster wrote: > >> Daniel P. Berrangé writes: > >> > >> > On Fri, Oct 30, 2020 at 11:11:19AM +0100, Markus Armbruster wrote: > >> >> Marc-An

Re: [PATCH 00/11] sockets: Attempt to drain the abstract socket swamp

2020-11-02 Thread Daniel P . Berrangé
On Mon, Nov 02, 2020 at 09:44:49AM +0100, Markus Armbruster wrote: > Daniel P. Berrangé writes: > > > On Fri, Oct 30, 2020 at 11:11:19AM +0100, Markus Armbruster wrote: > >> Marc-André Lureau writes: > >> > >> > Hi Markus, > >> > > >> > On Thu, Oct 29, 2020 at 5:43 PM Markus Armbruster > >> >

Re: [PATCH 00/11] sockets: Attempt to drain the abstract socket swamp

2020-11-02 Thread Paolo Bonzini
On 02/11/20 09:44, Markus Armbruster wrote: >>> Reverting the feature requires rough consensus and a patch. >>> >>> I can provide a patch, but let's give everybody a chance to object >>> first. > Daniel, do you object, yes or no? I think we should keep the patch, especially since you have cleaned

Re: [PATCH 00/11] sockets: Attempt to drain the abstract socket swamp

2020-11-02 Thread Markus Armbruster
Daniel P. Berrangé writes: > On Fri, Oct 30, 2020 at 11:11:19AM +0100, Markus Armbruster wrote: >> Marc-André Lureau writes: >> >> > Hi Markus, >> > >> > On Thu, Oct 29, 2020 at 5:43 PM Markus Armbruster >> > wrote: >> > >> >> In my opinion, the Linux-specific abstract UNIX domain socket feat

Re: [PATCH 00/11] sockets: Attempt to drain the abstract socket swamp

2020-10-30 Thread Daniel P . Berrangé
On Fri, Oct 30, 2020 at 11:11:19AM +0100, Markus Armbruster wrote: > Marc-André Lureau writes: > > > Hi Markus, > > > > On Thu, Oct 29, 2020 at 5:43 PM Markus Armbruster wrote: > > > >> In my opinion, the Linux-specific abstract UNIX domain socket feature > >> introduced in 5.1 should have been

Re: [PATCH 00/11] sockets: Attempt to drain the abstract socket swamp

2020-10-30 Thread Markus Armbruster
Paolo Bonzini writes: > On 29/10/20 14:38, Markus Armbruster wrote: >> In my opinion, the Linux-specific abstract UNIX domain socket feature >> introduced in 5.1 should have been rejected. The feature is niche, >> the interface clumsy, the implementation buggy and incomplete, and the >> test cov

Re: [PATCH 00/11] sockets: Attempt to drain the abstract socket swamp

2020-10-30 Thread Markus Armbruster
Marc-André Lureau writes: > Hi Markus, > > On Thu, Oct 29, 2020 at 5:43 PM Markus Armbruster wrote: > >> In my opinion, the Linux-specific abstract UNIX domain socket feature >> introduced in 5.1 should have been rejected. The feature is niche, >> the interface clumsy, the implementation buggy

Re: [PATCH 00/11] sockets: Attempt to drain the abstract socket swamp

2020-10-29 Thread Paolo Bonzini
On 29/10/20 14:38, Markus Armbruster wrote: > In my opinion, the Linux-specific abstract UNIX domain socket feature > introduced in 5.1 should have been rejected. The feature is niche, > the interface clumsy, the implementation buggy and incomplete, and the > test coverage insufficient. Review fa

Re: [PATCH 00/11] sockets: Attempt to drain the abstract socket swamp

2020-10-29 Thread Marc-André Lureau
Hi Markus, On Thu, Oct 29, 2020 at 5:43 PM Markus Armbruster wrote: > In my opinion, the Linux-specific abstract UNIX domain socket feature > introduced in 5.1 should have been rejected. The feature is niche, > the interface clumsy, the implementation buggy and incomplete, and the > test covera

[PATCH 00/11] sockets: Attempt to drain the abstract socket swamp

2020-10-29 Thread Markus Armbruster
In my opinion, the Linux-specific abstract UNIX domain socket feature introduced in 5.1 should have been rejected. The feature is niche, the interface clumsy, the implementation buggy and incomplete, and the test coverage insufficient. Review fail. Fixing the parts we can still fix now is regret