Re: [PATCH 00/13] microvm: add acpi support

2020-03-27 Thread Igor Mammedov
On Fri, 27 Mar 2020 13:06:28 +0100 Gerd Hoffmann wrote: > Hi, > > > I just quickly hacked hw-reduced acpi (using arm/virt as model) > > Can you send the patch or push a branch nevertheless? It's no suitable for patch but I pushed it to my github repo https://github.com/imammedo/qemu.git

Re: [PATCH 00/13] microvm: add acpi support

2020-03-27 Thread Gerd Hoffmann
Hi, > I just quickly hacked hw-reduced acpi (using arm/virt as model) Can you send the patch or push a branch nevertheless? thanks, Gerd

Re: [PATCH 00/13] microvm: add acpi support

2020-03-26 Thread Igor Mammedov
On Thu, 26 Mar 2020 03:33:35 -0400 "Michael S. Tsirkin" wrote: > On Wed, Mar 25, 2020 at 07:44:34PM +0100, Igor Mammedov wrote: > > On Wed, 25 Mar 2020 16:03:39 +0100 > > Gerd Hoffmann wrote: > > > > > On Wed, Mar 25, 2020 at 01:32:12PM +0100, Igor Mammedov wrote: > > > > On Thu, 19 Mar

Re: [PATCH 00/13] microvm: add acpi support

2020-03-26 Thread Michael S. Tsirkin
On Wed, Mar 25, 2020 at 07:44:34PM +0100, Igor Mammedov wrote: > On Wed, 25 Mar 2020 16:03:39 +0100 > Gerd Hoffmann wrote: > > > On Wed, Mar 25, 2020 at 01:32:12PM +0100, Igor Mammedov wrote: > > > On Thu, 19 Mar 2020 09:01:04 +0100 > > > Gerd Hoffmann wrote: > > > > > > > I know that not

Re: [PATCH 00/13] microvm: add acpi support

2020-03-25 Thread Igor Mammedov
On Wed, 25 Mar 2020 10:16:36 +0100 Gerd Hoffmann wrote: > > > mounted. Decided to use the "i8042: PNP: No PS/2 controller found." > > > line instead for a simple test (just check the kernel log timestamps, > > > three runs each). The ACPI initialization is already done at that > > > point, so

Re: [PATCH 00/13] microvm: add acpi support

2020-03-25 Thread Igor Mammedov
On Wed, 25 Mar 2020 16:03:39 +0100 Gerd Hoffmann wrote: > On Wed, Mar 25, 2020 at 01:32:12PM +0100, Igor Mammedov wrote: > > On Thu, 19 Mar 2020 09:01:04 +0100 > > Gerd Hoffmann wrote: > > > > > I know that not supporting ACPI in microvm is intentional. If you still > > > don't want ACPI

Re: [PATCH 00/13] microvm: add acpi support

2020-03-25 Thread Gerd Hoffmann
On Wed, Mar 25, 2020 at 01:32:12PM +0100, Igor Mammedov wrote: > On Thu, 19 Mar 2020 09:01:04 +0100 > Gerd Hoffmann wrote: > > > I know that not supporting ACPI in microvm is intentional. If you still > > don't want ACPI this is perfectly fine, you can use the usual -no-acpi > > switch to

Re: [PATCH 00/13] microvm: add acpi support

2020-03-25 Thread Igor Mammedov
On Thu, 19 Mar 2020 09:01:04 +0100 Gerd Hoffmann wrote: > I know that not supporting ACPI in microvm is intentional. If you still > don't want ACPI this is perfectly fine, you can use the usual -no-acpi > switch to toggle ACPI support. > > These are the advantages you are going to loose then:

Re: [PATCH 00/13] microvm: add acpi support

2020-03-25 Thread Igor Mammedov
On Wed, 25 Mar 2020 10:16:36 +0100 Gerd Hoffmann wrote: > > > mounted. Decided to use the "i8042: PNP: No PS/2 controller found." > > > line instead for a simple test (just check the kernel log timestamps, > > > three runs each). The ACPI initialization is already done at that > > > point, so

Re: [PATCH 00/13] microvm: add acpi support

2020-03-25 Thread Gerd Hoffmann
> > mounted. Decided to use the "i8042: PNP: No PS/2 controller found." > > line instead for a simple test (just check the kernel log timestamps, > > three runs each). The ACPI initialization is already done at that > > point, so it should be useful nevertheless. Here we go: > > > > Without

Re: [PATCH 00/13] microvm: add acpi support

2020-03-23 Thread Igor Mammedov
On Mon, 23 Mar 2020 13:09:48 +0100 Gerd Hoffmann wrote: > On Mon, Mar 23, 2020 at 06:51:10AM -0400, Michael S. Tsirkin wrote: > > On Thu, Mar 19, 2020 at 09:01:04AM +0100, Gerd Hoffmann wrote: > > > I know that not supporting ACPI in microvm is intentional. If you still > > > don't want ACPI

Re: [PATCH 00/13] microvm: add acpi support

2020-03-23 Thread Gerd Hoffmann
On Mon, Mar 23, 2020 at 06:51:10AM -0400, Michael S. Tsirkin wrote: > On Thu, Mar 19, 2020 at 09:01:04AM +0100, Gerd Hoffmann wrote: > > I know that not supporting ACPI in microvm is intentional. If you still > > don't want ACPI this is perfectly fine, you can use the usual -no-acpi > > switch to

Re: [PATCH 00/13] microvm: add acpi support

2020-03-23 Thread Michael S. Tsirkin
On Thu, Mar 19, 2020 at 09:01:04AM +0100, Gerd Hoffmann wrote: > I know that not supporting ACPI in microvm is intentional. If you still > don't want ACPI this is perfectly fine, you can use the usual -no-acpi > switch to toggle ACPI support. > > These are the advantages you are going to loose

Re: [PATCH 00/13] microvm: add acpi support

2020-03-20 Thread Paolo Bonzini
On 20/03/20 09:32, Gerd Hoffmann wrote: > Hmm, seems we should have that for better regression testing. > master branch doesn't build with pc+q35+isapc turned off: > > LINKx86_64-softmmu/qemu-system-x86_64 > hw/virtio/virtio-iommu.o: In function `virtio_iommu_get_bdf': >

Re: [PATCH 00/13] microvm: add acpi support

2020-03-20 Thread Gerd Hoffmann
On Thu, Mar 19, 2020 at 06:34:40PM +0100, Paolo Bonzini wrote: > On 19/03/20 14:40, Gerd Hoffmann wrote: > >> Also, can you confirm that it builds without CONFIG_I440FX and > >> CONFIG_Q35? You probably need to add "imply ACPI" and possibly some > >> '#include "config-devices.h"' and '#ifdef

Re: [PATCH 00/13] microvm: add acpi support

2020-03-19 Thread Paolo Bonzini
On 19/03/20 14:40, Gerd Hoffmann wrote: >> Also, can you confirm that it builds without CONFIG_I440FX and >> CONFIG_Q35? You probably need to add "imply ACPI" and possibly some >> '#include "config-devices.h"' and '#ifdef CONFIG_ACPI' here and there. > Hmm, is there some way to do this without

Re: [PATCH 00/13] microvm: add acpi support

2020-03-19 Thread Gerd Hoffmann
Hi, > Also, can you confirm that it builds without CONFIG_I440FX and > CONFIG_Q35? You probably need to add "imply ACPI" and possibly some > '#include "config-devices.h"' and '#ifdef CONFIG_ACPI' here and there. Hmm, is there some way to do this without modifying

Re: [PATCH 00/13] microvm: add acpi support

2020-03-19 Thread Gerd Hoffmann
Hi, > The main reason for not having ACPI was the time that it took to start; Yep, ACPI needs additional boot time. Shouldn't be a big difference though, microvm acpi only declares some devices and has small tables. Also no acpi methods, so no interpreter work. Maybe it is mostly the

Re: [PATCH 00/13] microvm: add acpi support

2020-03-19 Thread Paolo Bonzini
On 19/03/20 10:33, Gerd Hoffmann wrote: > On Thu, Mar 19, 2020 at 09:49:55AM +0100, Paolo Bonzini wrote: >> On 19/03/20 09:01, Gerd Hoffmann wrote: >>> I know that not supporting ACPI in microvm is intentional. If you still >>> don't want ACPI this is perfectly fine, you can use the usual

Re: [PATCH 00/13] microvm: add acpi support

2020-03-19 Thread Gerd Hoffmann
On Thu, Mar 19, 2020 at 09:49:55AM +0100, Paolo Bonzini wrote: > On 19/03/20 09:01, Gerd Hoffmann wrote: > > I know that not supporting ACPI in microvm is intentional. If you still > > don't want ACPI this is perfectly fine, you can use the usual -no-acpi > > switch to toggle ACPI support. > >

Re: [PATCH 00/13] microvm: add acpi support

2020-03-19 Thread Paolo Bonzini
On 19/03/20 09:01, Gerd Hoffmann wrote: > I know that not supporting ACPI in microvm is intentional. If you still > don't want ACPI this is perfectly fine, you can use the usual -no-acpi > switch to toggle ACPI support. Could we change -no-acpi into a "-machine acpi=..." property? Then it can

Re: [PATCH 00/13] microvm: add acpi support

2020-03-19 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200319080117.7725-1-kra...@redhat.com/ Hi, This series failed the docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!

Re: [PATCH 00/13] microvm: add acpi support

2020-03-19 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200319080117.7725-1-kra...@redhat.com/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN ===

Re: [PATCH 00/13] microvm: add acpi support

2020-03-19 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200319080117.7725-1-kra...@redhat.com/ Hi, This series failed the asan build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/bin/bash export

[PATCH 00/13] microvm: add acpi support

2020-03-19 Thread Gerd Hoffmann
I know that not supporting ACPI in microvm is intentional. If you still don't want ACPI this is perfectly fine, you can use the usual -no-acpi switch to toggle ACPI support. These are the advantages you are going to loose then: (1) virtio-mmio device discovery without command line hacks