Re: [PATCH 05/15] hw/riscv/boot.c: introduce riscv_default_firmware_name()

2022-12-23 Thread Bin Meng
On Thu, Dec 22, 2022 at 2:28 AM Daniel Henrique Barboza wrote: > > Some boards are duplicating the 'riscv_find_and_load_firmware' call > because the 32 and 64 bits images have different names. Create > a function to handle this detail instead of hardcoding it in the boards. > > Ideally we would

Re: [PATCH 05/15] hw/riscv/boot.c: introduce riscv_default_firmware_name()

2022-12-22 Thread Alistair Francis
On Thu, Dec 22, 2022 at 4:28 AM Daniel Henrique Barboza wrote: > > Some boards are duplicating the 'riscv_find_and_load_firmware' call > because the 32 and 64 bits images have different names. Create > a function to handle this detail instead of hardcoding it in the boards. > > Ideally we would

[PATCH 05/15] hw/riscv/boot.c: introduce riscv_default_firmware_name()

2022-12-21 Thread Daniel Henrique Barboza
Some boards are duplicating the 'riscv_find_and_load_firmware' call because the 32 and 64 bits images have different names. Create a function to handle this detail instead of hardcoding it in the boards. Ideally we would bake this logic inside riscv_find_and_load_firmware(), or even create a