Re: [PATCH 08/33] Add structs target_freebsd11_nstat and target_freebsd11_statfs to bsd-user/syscall_defs.h

2023-08-08 Thread Warner Losh
On Tue, Aug 8, 2023 at 10:41 PM Warner Losh wrote: > > > On Tue, Aug 8, 2023 at 9:12 PM Richard Henderson < > richard.hender...@linaro.org> wrote: > >> On 8/8/23 19:51, Warner Losh wrote: >> > > +/* __int32_t st_lspare; */ >> > >> > Why commented out? >> > >> > >> > I believe that t

Re: [PATCH 08/33] Add structs target_freebsd11_nstat and target_freebsd11_statfs to bsd-user/syscall_defs.h

2023-08-08 Thread Warner Losh
On Tue, Aug 8, 2023 at 9:12 PM Richard Henderson < richard.hender...@linaro.org> wrote: > On 8/8/23 19:51, Warner Losh wrote: > > > +/* __int32_t st_lspare; */ > > > > Why commented out? > > > > > > I believe that the element was a padding one > > > > > +struct target_f

Re: [PATCH 08/33] Add structs target_freebsd11_nstat and target_freebsd11_statfs to bsd-user/syscall_defs.h

2023-08-08 Thread Richard Henderson
On 8/8/23 19:51, Warner Losh wrote: > +    /* __int32_t  st_lspare; */ Why commented out? I believe that the element was a padding one > +    struct target_freebsd_timespec st_birthtim; /* time of file creation */ Does that not place st_birthtim at the wrong place?

Re: [PATCH 08/33] Add structs target_freebsd11_nstat and target_freebsd11_statfs to bsd-user/syscall_defs.h

2023-08-08 Thread Warner Losh
On Tue, Aug 8, 2023 at 3:24 PM Richard Henderson < richard.hender...@linaro.org> wrote: > On 8/7/23 23:07, Karim Taha wrote: > > +uint32_t st_flags;/* user defined flags for file */ > > +__uint32_t st_gen; /* file generation number */ > > Drop the __. > > > +/* __int32_t st

Re: [PATCH 08/33] Add structs target_freebsd11_nstat and target_freebsd11_statfs to bsd-user/syscall_defs.h

2023-08-08 Thread Richard Henderson
On 8/7/23 23:07, Karim Taha wrote: +uint32_t st_flags;/* user defined flags for file */ +__uint32_t st_gen; /* file generation number */ Drop the __. +/* __int32_t st_lspare; */ Why commented out? +struct target_freebsd_timespec st_birthtim; /* time of file cre

[PATCH 08/33] Add structs target_freebsd11_nstat and target_freebsd11_statfs to bsd-user/syscall_defs.h

2023-08-08 Thread Karim Taha
From: Stacey Son Signed-off-by: Stacey Son Signed-off-by: Karim Taha --- bsd-user/syscall_defs.h | 65 + 1 file changed, 65 insertions(+) diff --git a/bsd-user/syscall_defs.h b/bsd-user/syscall_defs.h index e796e7e13d..06be8244de 100644 --- a/bsd-user/s