Paolo Bonzini writes:
> On 27/05/20 17:05, Peter Maydell wrote:
>> I disagree with these. We're in a realize function, the API
>> says "on errors, report them via the Error* you got passed",
>> so we should do that, not blow up. &error_abort only makes
>> sense if (a) we have no better way to rep
Peter Maydell writes:
> On Wed, 27 May 2020 at 15:12, Markus Armbruster wrote:
>> * PATCH 08: in a realize method. Can't actually fail, so let's use
>> &error_abort.
>>
>> * PATCH 09 (this one): likewise.
>
> I disagree with these. We're in a realize function, the API
> says "on errors, repor
On 27/05/20 17:05, Peter Maydell wrote:
> I disagree with these. We're in a realize function, the API
> says "on errors, report them via the Error* you got passed",
> so we should do that, not blow up. &error_abort only makes
> sense if (a) we have no better way to report errors than
> to abort (wh
On Wed, 27 May 2020 at 15:12, Markus Armbruster wrote:
> * PATCH 08: in a realize method. Can't actually fail, so let's use
> &error_abort.
>
> * PATCH 09 (this one): likewise.
I disagree with these. We're in a realize function, the API
says "on errors, report them via the Error* you got passe
Peter Maydell writes:
[...]
> Since we init the device with sysbus_init_child_obj() and
> we're in a position here to propagate any realize error
> back up to our caller, it would be nicer to do this via
> setting the realize property rather than qdev_init_nofail().
I checked all my patches for
Peter Maydell writes:
> On Mon, 18 May 2020 at 06:12, Markus Armbruster wrote:
>>
>> cuda_init() creates a "mos6522-cuda" device, but it's never realized.
>> Affects machines mac99 with via=cuda (default) and g3beige.
>>
>> pmu_init() creates a "mos6522-pmu" device, but it's never realized.
>> A
On Mon, 18 May 2020 at 06:12, Markus Armbruster wrote:
>
> cuda_init() creates a "mos6522-cuda" device, but it's never realized.
> Affects machines mac99 with via=cuda (default) and g3beige.
>
> pmu_init() creates a "mos6522-pmu" device, but it's never realized.
> Affects machine mac99 with via=pm
cuda_init() creates a "mos6522-cuda" device, but it's never realized.
Affects machines mac99 with via=cuda (default) and g3beige.
pmu_init() creates a "mos6522-pmu" device, but it's never realized.
Affects machine mac99 with via=pmu and via=pmu-adb,
I wonder how this ever worked. If the "device
