Re: [PATCH 1/2] system/vl.c: do not allow mixed -accel opts

2024-07-01 Thread Paolo Bonzini
On Mon, Jul 1, 2024 at 5:53 PM Daniel Henrique Barboza wrote: > > We use '-accel kvm -accel tcg' to allow kvm to fail (e.g. no /dev/kvm > > permission) and proceed with tcg. > > > > This patch will cause testsuite failures. > > For the issue I want to fix patch 2 alone is enough. I'll re-send. I

Re: [PATCH 1/2] system/vl.c: do not allow mixed -accel opts

2024-07-01 Thread Daniel Henrique Barboza
On 7/1/24 12:23 PM, Richard Henderson wrote: On 7/1/24 06:30, Daniel Henrique Barboza wrote: We're allowing multiple -accel options to be used with different accelerators, even though we don't have any machine that supports mixed acceleration. In fact, it will only parse the first occurence

Re: [PATCH 1/2] system/vl.c: do not allow mixed -accel opts

2024-07-01 Thread Richard Henderson
On 7/1/24 06:30, Daniel Henrique Barboza wrote: We're allowing multiple -accel options to be used with different accelerators, even though we don't have any machine that supports mixed acceleration. In fact, it will only parse the first occurence of -accel and, aside from a help option (e.g. -ac

[PATCH 1/2] system/vl.c: do not allow mixed -accel opts

2024-07-01 Thread Daniel Henrique Barboza
We're allowing multiple -accel options to be used with different accelerators, even though we don't have any machine that supports mixed acceleration. In fact, it will only parse the first occurence of -accel and, aside from a help option (e.g. -accel help) that will always cause the process to pr