Re: [PATCH 1/4] apic: add support for x2APIC mode

2023-03-07 Thread Igor Mammedov
On Mon, 06 Mar 2023 16:50:29 + David Woodhouse wrote: > On Mon, 2023-03-06 at 23:39 +0700, Bui Quang Minh wrote: > > On 3/6/23 22:51, David Woodhouse wrote: > > > On Mon, 2023-03-06 at 11:43 +0100, Igor Mammedov wrote: > > > > > However, there are still problems while trying to extending

Re: [PATCH 1/4] apic: add support for x2APIC mode

2023-03-07 Thread Igor Mammedov
On Mon, 06 Mar 2023 15:51:45 + David Woodhouse wrote: > On Mon, 2023-03-06 at 11:43 +0100, Igor Mammedov wrote: > > > However, there are still problems while trying to extending support to > > > APIC ID larger than 255 because there are many places assume APIC ID is > > > 8-bit long. > >

Re: [PATCH 1/4] apic: add support for x2APIC mode

2023-03-06 Thread David Woodhouse
On Mon, 2023-03-06 at 23:39 +0700, Bui Quang Minh wrote: > On 3/6/23 22:51, David Woodhouse wrote: > > On Mon, 2023-03-06 at 11:43 +0100, Igor Mammedov wrote: > > > > However, there are still problems while trying to extending support to > > > > APIC ID larger than 255 because there are many places

Re: [PATCH 1/4] apic: add support for x2APIC mode

2023-03-06 Thread Bui Quang Minh
On 3/6/23 22:51, David Woodhouse wrote: On Mon, 2023-03-06 at 11:43 +0100, Igor Mammedov wrote: However, there are still problems while trying to extending support to APIC ID larger than 255 because there are many places assume APIC ID is 8-bit long. that's what I was concerned about (i.e. jus

Re: [PATCH 1/4] apic: add support for x2APIC mode

2023-03-06 Thread David Woodhouse
On Tue, 2023-02-21 at 23:04 +0700, Bui Quang Minh wrote: > @@ -454,7 +500,7 @@ static int apic_find_dest(uint8_t dest) >  } >   >  static void apic_get_delivery_bitmask(uint32_t *deliver_bitmask, > -  uint8_t dest, uint8_t dest_mode) > +  

Re: [PATCH 1/4] apic: add support for x2APIC mode

2023-03-06 Thread David Woodhouse
On Mon, 2023-03-06 at 11:43 +0100, Igor Mammedov wrote: > > However, there are still problems while trying to extending support to > > APIC ID larger than 255 because there are many places assume APIC ID is > > 8-bit long. > > that's what I was concerned about (i.e. just enabling x2apic without f

Re: [PATCH 1/4] apic: add support for x2APIC mode

2023-03-06 Thread Igor Mammedov
On Sat, 4 Mar 2023 21:10:54 +0700 Bui Quang Minh wrote: > On 2/28/23 23:39, Igor Mammedov wrote: > > On Tue, 28 Feb 2023 21:34:33 +0700 > > Bui Quang Minh wrote: > > > >> On 2/27/23 23:07, Igor Mammedov wrote: > >>> On Sat, 25 Feb 2023 17:15:17 +0700 > >>> Bui Quang Minh wrote: > >>>

Re: [PATCH 1/4] apic: add support for x2APIC mode

2023-03-04 Thread Bui Quang Minh
On 2/28/23 23:39, Igor Mammedov wrote: On Tue, 28 Feb 2023 21:34:33 +0700 Bui Quang Minh wrote: On 2/27/23 23:07, Igor Mammedov wrote: On Sat, 25 Feb 2023 17:15:17 +0700 Bui Quang Minh wrote: On 2/24/23 21:29, Igor Mammedov wrote: On Tue, 21 Feb 2023 23:04:57 +0700 Bui Quang Minh wrot

Re: [PATCH 1/4] apic: add support for x2APIC mode

2023-02-28 Thread Igor Mammedov
On Tue, 28 Feb 2023 21:34:33 +0700 Bui Quang Minh wrote: > On 2/27/23 23:07, Igor Mammedov wrote: > > On Sat, 25 Feb 2023 17:15:17 +0700 > > Bui Quang Minh wrote: > > > >> On 2/24/23 21:29, Igor Mammedov wrote: > >>> On Tue, 21 Feb 2023 23:04:57 +0700 > >>> Bui Quang Minh wrote: > >>>

Re: [PATCH 1/4] apic: add support for x2APIC mode

2023-02-28 Thread Bui Quang Minh
On 2/27/23 23:07, Igor Mammedov wrote: On Sat, 25 Feb 2023 17:15:17 +0700 Bui Quang Minh wrote: On 2/24/23 21:29, Igor Mammedov wrote: On Tue, 21 Feb 2023 23:04:57 +0700 Bui Quang Minh wrote: This commit refactors APIC registers read/write function to support both MMIO read/write in xAP

Re: [PATCH 1/4] apic: add support for x2APIC mode

2023-02-27 Thread Igor Mammedov
On Sat, 25 Feb 2023 17:15:17 +0700 Bui Quang Minh wrote: > On 2/24/23 21:29, Igor Mammedov wrote: > > On Tue, 21 Feb 2023 23:04:57 +0700 > > Bui Quang Minh wrote: > > > >> This commit refactors APIC registers read/write function to support both > >> MMIO read/write in xAPIC mode and MSR read/

Re: [PATCH 1/4] apic: add support for x2APIC mode

2023-02-25 Thread Bui Quang Minh
On 2/24/23 21:29, Igor Mammedov wrote: On Tue, 21 Feb 2023 23:04:57 +0700 Bui Quang Minh wrote: This commit refactors APIC registers read/write function to support both MMIO read/write in xAPIC mode and MSR read/write in x2APIC mode. Also, support larger APIC ID, self IPI, new IPI destination

Re: [PATCH 1/4] apic: add support for x2APIC mode

2023-02-24 Thread Igor Mammedov
On Tue, 21 Feb 2023 23:04:57 +0700 Bui Quang Minh wrote: > This commit refactors APIC registers read/write function to support both > MMIO read/write in xAPIC mode and MSR read/write in x2APIC mode. Also, > support larger APIC ID, self IPI, new IPI destination determination in > x2APIC mode. > >

[PATCH 1/4] apic: add support for x2APIC mode

2023-02-21 Thread Bui Quang Minh
This commit refactors APIC registers read/write function to support both MMIO read/write in xAPIC mode and MSR read/write in x2APIC mode. Also, support larger APIC ID, self IPI, new IPI destination determination in x2APIC mode. Signed-off-by: Bui Quang Minh --- hw/intc/apic.c |