Re: [PATCH 1/4] hw/intc/loongarch_ipi: Bring back all 4 IPI mailboxes

2023-06-03 Thread Song Gao
在 2023/5/21 下午6:23, Jiaxun Yang 写道: As per "Loongson 3A5000/3B5000 Processor Reference Manual", Loongson 3A5000's IPI implementation have 4 mailboxes per core. However, in 78464f023b54 ("hw/loongarch/virt: Modify ipi as percpu device"), the number of IPI mailboxes was reduced to one, which mi

Re: [PATCH 1/4] hw/intc/loongarch_ipi: Bring back all 4 IPI mailboxes

2023-06-03 Thread bibo, mao
在 2023/5/23 21:07, Philippe Mathieu-Daudé 写道: > On 23/5/23 13:18, Jiaxun Yang wrote: >> >> >>> 2023年5月23日 11:01,Song Gao 写道: >>> >>> >>> >>> 在 2023/5/23 上午11:22, Jiaxun Yang 写道: >> [...] > Is totally the same on MIPS and LoongArch. I’m guarding them out because We have differ

Re: [PATCH 1/4] hw/intc/loongarch_ipi: Bring back all 4 IPI mailboxes

2023-06-03 Thread Song Gao
在 2023/6/3 下午3:06, Jiaxun Yang 写道: 2023年6月3日 01:28,Peter Maydell 写道: On Sun, 21 May 2023 at 11:24, Jiaxun Yang wrote: As per "Loongson 3A5000/3B5000 Processor Reference Manual", Loongson 3A5000's IPI implementation have 4 mailboxes per core. However, in 78464f023b54 ("hw/loongarch/virt:

Re: [PATCH 1/4] hw/intc/loongarch_ipi: Bring back all 4 IPI mailboxes

2023-06-03 Thread Jiaxun Yang
> 2023年6月3日 01:28,Peter Maydell 写道: > > On Sun, 21 May 2023 at 11:24, Jiaxun Yang wrote: >> >> As per "Loongson 3A5000/3B5000 Processor Reference Manual", >> Loongson 3A5000's IPI implementation have 4 mailboxes per >> core. >> >> However, in 78464f023b54 ("hw/loongarch/virt: Modify ipi as

Re: [PATCH 1/4] hw/intc/loongarch_ipi: Bring back all 4 IPI mailboxes

2023-06-02 Thread Peter Maydell
On Sun, 21 May 2023 at 11:24, Jiaxun Yang wrote: > > As per "Loongson 3A5000/3B5000 Processor Reference Manual", > Loongson 3A5000's IPI implementation have 4 mailboxes per > core. > > However, in 78464f023b54 ("hw/loongarch/virt: Modify ipi as > percpu device"), the number of IPI mailboxes was re

Re: [PATCH 1/4] hw/intc/loongarch_ipi: Bring back all 4 IPI mailboxes

2023-05-23 Thread Philippe Mathieu-Daudé
On 23/5/23 13:18, Jiaxun Yang wrote: 2023年5月23日 11:01,Song Gao 写道: 在 2023/5/23 上午11:22, Jiaxun Yang 写道: [...] Is totally the same on MIPS and LoongArch. I’m guarding them out because We have different way to get IOCSR address space on MIPS, which is due to be implemented. I can furt

Re: [PATCH 1/4] hw/intc/loongarch_ipi: Bring back all 4 IPI mailboxes

2023-05-23 Thread Jiaxun Yang
> 2023年5月23日 11:01,Song Gao 写道: > > > > 在 2023/5/23 上午11:22, Jiaxun Yang 写道: [...] >> >>> >> Is totally the same on MIPS and LoongArch. I’m guarding them out because >> We have different way to get IOCSR address space on MIPS, which is due >> to be implemented. >> >> I can further abstrac

Re: [PATCH 1/4] hw/intc/loongarch_ipi: Bring back all 4 IPI mailboxes

2023-05-23 Thread Song Gao
在 2023/5/23 上午11:22, Jiaxun Yang 写道: 2023年5月23日 02:25,Song Gao 写道: 在 2023/5/22 下午9:44, Philippe Mathieu-Daudé 写道: On 22/5/23 13:47, Jiaxun Yang wrote: 2023年5月22日 04:52,Huacai Chen 写道: Hi, Jiaxun, Rename loongarch_ipi to loongson_ipi? It will be shared by both MIPS and LoongArch in

Re: [PATCH 1/4] hw/intc/loongarch_ipi: Bring back all 4 IPI mailboxes

2023-05-22 Thread Jiaxun Yang
> 2023年5月23日 02:25,Song Gao 写道: > > > > 在 2023/5/22 下午9:44, Philippe Mathieu-Daudé 写道: >> On 22/5/23 13:47, Jiaxun Yang wrote: >>> >>> 2023年5月22日 04:52,Huacai Chen 写道: Hi, Jiaxun, Rename loongarch_ipi to loongson_ipi? It will be shared by both MIPS and Loon

Re: [PATCH 1/4] hw/intc/loongarch_ipi: Bring back all 4 IPI mailboxes

2023-05-22 Thread Song Gao
在 2023/5/22 下午9:44, Philippe Mathieu-Daudé 写道: On 22/5/23 13:47, Jiaxun Yang wrote: 2023年5月22日 04:52,Huacai Chen 写道: Hi, Jiaxun, Rename loongarch_ipi to loongson_ipi? It will be shared by both MIPS and LoongArch in your series. Hi Huacai, Thanks for the point, what’s the opinion from

Re: [PATCH 1/4] hw/intc/loongarch_ipi: Bring back all 4 IPI mailboxes

2023-05-22 Thread Philippe Mathieu-Daudé
On 22/5/23 13:47, Jiaxun Yang wrote: 2023年5月22日 04:52,Huacai Chen 写道: Hi, Jiaxun, Rename loongarch_ipi to loongson_ipi? It will be shared by both MIPS and LoongArch in your series. Hi Huacai, Thanks for the point, what’s the opinion from LoongArch mainatiners? Or perhaps rename it as lo

Re: [PATCH 1/4] hw/intc/loongarch_ipi: Bring back all 4 IPI mailboxes

2023-05-22 Thread Jiaxun Yang
> 2023年5月22日 04:52,Huacai Chen 写道: > > Hi, Jiaxun, > > Rename loongarch_ipi to loongson_ipi? It will be shared by both MIPS > and LoongArch in your series. Hi Huacai, Thanks for the point, what’s the opinion from LoongArch mainatiners? Or perhaps rename it as loong_ipi to reflect the natur

Re: [PATCH 1/4] hw/intc/loongarch_ipi: Bring back all 4 IPI mailboxes

2023-05-21 Thread Huacai Chen
Hi, Jiaxun, Rename loongarch_ipi to loongson_ipi? It will be shared by both MIPS and LoongArch in your series. Huacai On Sun, May 21, 2023 at 6:24 PM Jiaxun Yang wrote: > > As per "Loongson 3A5000/3B5000 Processor Reference Manual", > Loongson 3A5000's IPI implementation have 4 mailboxes per >

[PATCH 1/4] hw/intc/loongarch_ipi: Bring back all 4 IPI mailboxes

2023-05-21 Thread Jiaxun Yang
As per "Loongson 3A5000/3B5000 Processor Reference Manual", Loongson 3A5000's IPI implementation have 4 mailboxes per core. However, in 78464f023b54 ("hw/loongarch/virt: Modify ipi as percpu device"), the number of IPI mailboxes was reduced to one, which mismatches actual hardware. It won't affec