Re: [PATCH 1/5] target/riscv: Fix effective address for pointer mask

2023-03-28 Thread liweiwei
On 2023/3/28 15:25, LIU Zhiwei wrote: On 2023/3/28 11:33, liweiwei wrote: On 2023/3/28 11:18, Richard Henderson wrote: On 3/27/23 19:48, liweiwei wrote: On 2023/3/28 10:20, LIU Zhiwei wrote: On 2023/3/27 18:00, Weiwei Li wrote: Since pointer mask works on effective address, and the xl

Re: [PATCH 1/5] target/riscv: Fix effective address for pointer mask

2023-03-28 Thread LIU Zhiwei
On 2023/3/28 11:33, liweiwei wrote: On 2023/3/28 11:18, Richard Henderson wrote: On 3/27/23 19:48, liweiwei wrote: On 2023/3/28 10:20, LIU Zhiwei wrote: On 2023/3/27 18:00, Weiwei Li wrote: Since pointer mask works on effective address, and the xl works on the generation of effective

Re: [PATCH 1/5] target/riscv: Fix effective address for pointer mask

2023-03-27 Thread liweiwei
On 2023/3/28 11:18, Richard Henderson wrote: On 3/27/23 19:48, liweiwei wrote: On 2023/3/28 10:20, LIU Zhiwei wrote: On 2023/3/27 18:00, Weiwei Li wrote: Since pointer mask works on effective address, and the xl works on the generation of effective address, so xl related calculation should

Re: [PATCH 1/5] target/riscv: Fix effective address for pointer mask

2023-03-27 Thread LIU Zhiwei
On 2023/3/28 11:18, Richard Henderson wrote: On 3/27/23 19:48, liweiwei wrote: On 2023/3/28 10:20, LIU Zhiwei wrote: On 2023/3/27 18:00, Weiwei Li wrote: Since pointer mask works on effective address, and the xl works on the generation of effective address, so xl related calculation

Re: [PATCH 1/5] target/riscv: Fix effective address for pointer mask

2023-03-27 Thread Richard Henderson
On 3/27/23 19:48, liweiwei wrote: On 2023/3/28 10:20, LIU Zhiwei wrote: On 2023/3/27 18:00, Weiwei Li wrote: Since pointer mask works on effective address, and the xl works on the generation of effective address, so xl related calculation should be done before pointer mask. Incorrect. It

Re: [PATCH 1/5] target/riscv: Fix effective address for pointer mask

2023-03-27 Thread liweiwei
On 2023/3/28 10:20, LIU Zhiwei wrote: On 2023/3/27 18:00, Weiwei Li wrote: Since pointer mask works on effective address, and the xl works on the generation of effective address, so xl related calculation should be done before pointer mask. Incorrect. It has been done. When updating the

Re: [PATCH 1/5] target/riscv: Fix effective address for pointer mask

2023-03-27 Thread LIU Zhiwei
On 2023/3/27 18:00, Weiwei Li wrote: Since pointer mask works on effective address, and the xl works on the generation of effective address, so xl related calculation should be done before pointer mask. Incorrect. It has been done. When updating the pm_mask,  we have already considered the

Re: [PATCH 1/5] target/riscv: Fix effective address for pointer mask

2023-03-27 Thread Daniel Henrique Barboza
On 3/27/23 07:00, Weiwei Li wrote: Since pointer mask works on effective address, and the xl works on the generation of effective address, so xl related calculation should be done nit: I believe you can remove the 'so' before pointer mask. Signed-off-by: Weiwei Li Signed-off-by:

[PATCH 1/5] target/riscv: Fix effective address for pointer mask

2023-03-27 Thread Weiwei Li
Since pointer mask works on effective address, and the xl works on the generation of effective address, so xl related calculation should be done before pointer mask. Signed-off-by: Weiwei Li Signed-off-by: Junqiang Wang --- target/riscv/translate.c | 16 1 file changed, 12