Re: [PATCH 1/9] linux-user: Diagnose incorrect -R size

2023-03-17 Thread Peter Maydell
On Fri, 17 Mar 2023 at 14:57, Peter Maydell wrote: > > On Fri, 17 Mar 2023 at 14:46, Richard Henderson > wrote: > > > > On 3/7/23 02:17, Peter Maydell wrote: > > > It looks like we (inadvertently) broke "-R 0 means turn off" > > > in 2019 with commit dc18baaef36d95e5; prior to that the > > > 64-o

Re: [PATCH 1/9] linux-user: Diagnose incorrect -R size

2023-03-17 Thread Peter Maydell
On Fri, 17 Mar 2023 at 14:46, Richard Henderson wrote: > > On 3/7/23 02:17, Peter Maydell wrote: > > It looks like we (inadvertently) broke "-R 0 means turn off" > > in 2019 with commit dc18baaef36d95e5; prior to that the > > 64-on-32 default was set by the initial value of the global > > variable

Re: [PATCH 1/9] linux-user: Diagnose incorrect -R size

2023-03-17 Thread Richard Henderson
On 3/7/23 02:17, Peter Maydell wrote: It looks like we (inadvertently) broke "-R 0 means turn off" in 2019 with commit dc18baaef36d95e5; prior to that the 64-on-32 default was set by the initial value of the global variable and could be overridden on the command line. After that we ended up doing

Re: [PATCH 1/9] linux-user: Diagnose incorrect -R size

2023-03-07 Thread Peter Maydell
On Tue, 7 Mar 2023 at 10:12, Peter Maydell wrote: > > On Mon, 6 Mar 2023 at 21:24, Richard Henderson > wrote: > > > > On 3/6/23 04:56, Peter Maydell wrote: > > > On Mon, 6 Mar 2023 at 02:14, Richard Henderson > > > wrote: > > >> > > >> Zero is the value for 'off', and should not be used with -R.

Re: [PATCH 1/9] linux-user: Diagnose incorrect -R size

2023-03-07 Thread Peter Maydell
On Mon, 6 Mar 2023 at 21:24, Richard Henderson wrote: > > On 3/6/23 04:56, Peter Maydell wrote: > > On Mon, 6 Mar 2023 at 02:14, Richard Henderson > > wrote: > >> > >> Zero is the value for 'off', and should not be used with -R. > >> We have been enforcing host page alignment for the non-R > >> f

Re: [PATCH 1/9] linux-user: Diagnose incorrect -R size

2023-03-06 Thread Richard Henderson
On 3/6/23 04:56, Peter Maydell wrote: On Mon, 6 Mar 2023 at 02:14, Richard Henderson wrote: Zero is the value for 'off', and should not be used with -R. We have been enforcing host page alignment for the non-R fallback of MAX_RESERVED_VA, but failing to enforce for -R. I'm pretty sure we hav

Re: [PATCH 1/9] linux-user: Diagnose incorrect -R size

2023-03-06 Thread Peter Maydell
On Mon, 6 Mar 2023 at 02:14, Richard Henderson wrote: > > Zero is the value for 'off', and should not be used with -R. > We have been enforcing host page alignment for the non-R > fallback of MAX_RESERVED_VA, but failing to enforce for -R. I'm pretty sure we have users who specifically use "-R 0"

[PATCH 1/9] linux-user: Diagnose incorrect -R size

2023-03-05 Thread Richard Henderson
Zero is the value for 'off', and should not be used with -R. We have been enforcing host page alignment for the non-R fallback of MAX_RESERVED_VA, but failing to enforce for -R. Signed-off-by: Richard Henderson --- linux-user/main.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a