Re: [PATCH 2/3] target/ppc: Update VMX storage access insns to use tcg_gen_qemu_ld/st_i128.

2024-06-21 Thread Richard Henderson
On 6/21/24 09:34, Richard Henderson wrote: On 6/21/24 04:46, Chinmay Rath wrote: +    tcg_gen_qemu_ld_i128(avr, EA, ctx->mem_idx, DEF_MEMOP(MO_128)); +    set_avr_full(a->rt, avr); This needs to specify atomicity as well.  This is much more important to for 16 byte operations than smaller acc

Re: [PATCH 2/3] target/ppc: Update VMX storage access insns to use tcg_gen_qemu_ld/st_i128.

2024-06-21 Thread Richard Henderson
On 6/21/24 04:46, Chinmay Rath wrote: +tcg_gen_qemu_ld_i128(avr, EA, ctx->mem_idx, DEF_MEMOP(MO_128)); +set_avr_full(a->rt, avr); This needs to specify atomicity as well. This is much more important to for 16 byte operations than smaller accesses, as this might require stop-the-world

[PATCH 2/3] target/ppc: Update VMX storage access insns to use tcg_gen_qemu_ld/st_i128.

2024-06-21 Thread Chinmay Rath
Updated instructions {l, st}vx to use tcg_gen_qemu_ld/st_i128, instead of using 64 bits loads/stores in succession. Introduced functions {get, set}_avr_full in vmx-impl.c.inc to facilitate the above, and potential future usage. Suggested-by: Richard Henderson Signed-off-by: Chinmay Rath --- tar