Re: [PATCH 45/50] lasips2: use qdev gpio for output IRQ

2022-06-24 Thread Mark Cave-Ayland
On 20/06/2022 15:13, Peter Maydell wrote: On Mon, 20 Jun 2022 at 14:22, Mark Cave-Ayland wrote: On 20/06/2022 11:17, Peter Maydell wrote: Well, I think that "unnamed GPIO out" lines should be for actual GPIO lines, ie on a GPIO controller or similar. If you want an outbound IRQ line and don'

Re: [PATCH 45/50] lasips2: use qdev gpio for output IRQ

2022-06-20 Thread Peter Maydell
On Mon, 20 Jun 2022 at 14:22, Mark Cave-Ayland wrote: > > On 20/06/2022 11:17, Peter Maydell wrote: > > Well, I think that "unnamed GPIO out" lines should be for > > actual GPIO lines, ie on a GPIO controller or similar. > > If you want an outbound IRQ line and don't want to name it, > > that's wh

Re: [PATCH 45/50] lasips2: use qdev gpio for output IRQ

2022-06-20 Thread Mark Cave-Ayland
On 20/06/2022 11:17, Peter Maydell wrote: On Sat, 11 Jun 2022 at 16:44, Mark Cave-Ayland wrote: On 10/06/2022 08:17, Mark Cave-Ayland wrote: On 09/06/2022 12:18, Peter Maydell wrote: If you find yourself #defining names for IRQ lines then this is probably a sign you should be using named G

Re: [PATCH 45/50] lasips2: use qdev gpio for output IRQ

2022-06-20 Thread Peter Maydell
On Sat, 11 Jun 2022 at 16:44, Mark Cave-Ayland wrote: > > On 10/06/2022 08:17, Mark Cave-Ayland wrote: > > > On 09/06/2022 12:18, Peter Maydell wrote: > >> If you find yourself #defining names for IRQ lines then this is > >> probably a sign you should be using named GPIO lines :-) > > > > Yeah tha

Re: [PATCH 45/50] lasips2: use qdev gpio for output IRQ

2022-06-13 Thread Philippe Mathieu-Daudé via
On 22/5/22 20:18, Mark Cave-Ayland wrote: This enables the IRQ to be wired up using qdev_connect_gpio_out() in lasips2_initfn(). Signed-off-by: Mark Cave-Ayland --- hw/input/lasips2.c | 8 include/hw/input/lasips2.h | 2 ++ 2 files changed, 6 insertions(+), 4 deletions(-)

Re: [PATCH 45/50] lasips2: use qdev gpio for output IRQ

2022-06-11 Thread Mark Cave-Ayland
On 10/06/2022 08:17, Mark Cave-Ayland wrote: On 09/06/2022 12:18, Peter Maydell wrote: On Sun, 22 May 2022 at 19:20, Mark Cave-Ayland wrote: This enables the IRQ to be wired up using qdev_connect_gpio_out() in lasips2_initfn(). Signed-off-by: Mark Cave-Ayland ---   hw/input/lasips2.c 

Re: [PATCH 45/50] lasips2: use qdev gpio for output IRQ

2022-06-10 Thread Mark Cave-Ayland
On 09/06/2022 12:18, Peter Maydell wrote: On Sun, 22 May 2022 at 19:20, Mark Cave-Ayland wrote: This enables the IRQ to be wired up using qdev_connect_gpio_out() in lasips2_initfn(). Signed-off-by: Mark Cave-Ayland --- hw/input/lasips2.c | 8 include/hw/input/lasips2.h |

Re: [PATCH 45/50] lasips2: use qdev gpio for output IRQ

2022-06-09 Thread Peter Maydell
On Sun, 22 May 2022 at 19:20, Mark Cave-Ayland wrote: > > This enables the IRQ to be wired up using qdev_connect_gpio_out() in > lasips2_initfn(). > > Signed-off-by: Mark Cave-Ayland > --- > hw/input/lasips2.c | 8 > include/hw/input/lasips2.h | 2 ++ > 2 files changed, 6 insert

[PATCH 45/50] lasips2: use qdev gpio for output IRQ

2022-05-22 Thread Mark Cave-Ayland
This enables the IRQ to be wired up using qdev_connect_gpio_out() in lasips2_initfn(). Signed-off-by: Mark Cave-Ayland --- hw/input/lasips2.c | 8 include/hw/input/lasips2.h | 2 ++ 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/hw/input/lasips2.c b/hw/input/lasi