Re: [PATCH for-6.0 v2 1/2] hw/block/nvme: fix invalid msix exclusive uninit

2021-04-26 Thread Peter Maydell
On Fri, 23 Apr 2021 at 06:21, Klaus Jensen wrote: > > From: Klaus Jensen > > Commit 1901b4967c3f changed the nvme device from using a bar exclusive > for MSI-x to sharing it on bar0. > > Unfortunately, the msix_uninit_exclusive_bar() call remains in > nvme_exit() which causes havoc when the devic

Re: [PATCH for-6.0 v2 1/2] hw/block/nvme: fix invalid msix exclusive uninit

2021-04-26 Thread Michael S. Tsirkin
On Mon, Apr 26, 2021 at 11:27:04AM +0200, Philippe Mathieu-Daudé wrote: > On 4/26/21 6:40 AM, Klaus Jensen wrote: > > On Apr 23 07:21, Klaus Jensen wrote: > >> From: Klaus Jensen > >> > >> Commit 1901b4967c3f changed the nvme device from using a bar exclusive > >> for MSI-x to sharing it on bar0.

Re: [PATCH for-6.0 v2 1/2] hw/block/nvme: fix invalid msix exclusive uninit

2021-04-26 Thread Klaus Jensen
On Apr 26 11:27, Philippe Mathieu-Daudé wrote: On 4/26/21 6:40 AM, Klaus Jensen wrote: On Apr 23 07:21, Klaus Jensen wrote: From: Klaus Jensen Commit 1901b4967c3f changed the nvme device from using a bar exclusive for MSI-x to sharing it on bar0. Unfortunately, the msix_uninit_exclusive_bar(

Re: [PATCH for-6.0 v2 1/2] hw/block/nvme: fix invalid msix exclusive uninit

2021-04-26 Thread Philippe Mathieu-Daudé
On 4/26/21 6:40 AM, Klaus Jensen wrote: > On Apr 23 07:21, Klaus Jensen wrote: >> From: Klaus Jensen >> >> Commit 1901b4967c3f changed the nvme device from using a bar exclusive >> for MSI-x to sharing it on bar0. >> >> Unfortunately, the msix_uninit_exclusive_bar() call remains in >> nvme_exit()

Re: [PATCH for-6.0 v2 1/2] hw/block/nvme: fix invalid msix exclusive uninit

2021-04-25 Thread Klaus Jensen
On Apr 23 07:21, Klaus Jensen wrote: From: Klaus Jensen Commit 1901b4967c3f changed the nvme device from using a bar exclusive for MSI-x to sharing it on bar0. Unfortunately, the msix_uninit_exclusive_bar() call remains in nvme_exit() which causes havoc when the device is removed with, say, de

Re: [PATCH for-6.0 v2 1/2] hw/block/nvme: fix invalid msix exclusive uninit

2021-04-23 Thread Peter Maydell
On Fri, 23 Apr 2021 at 06:21, Klaus Jensen wrote: > > From: Klaus Jensen > > Commit 1901b4967c3f changed the nvme device from using a bar exclusive > for MSI-x to sharing it on bar0. > > Unfortunately, the msix_uninit_exclusive_bar() call remains in > nvme_exit() which causes havoc when the devic

[PATCH for-6.0 v2 1/2] hw/block/nvme: fix invalid msix exclusive uninit

2021-04-22 Thread Klaus Jensen
From: Klaus Jensen Commit 1901b4967c3f changed the nvme device from using a bar exclusive for MSI-x to sharing it on bar0. Unfortunately, the msix_uninit_exclusive_bar() call remains in nvme_exit() which causes havoc when the device is removed with, say, device_del. Fix this. Additionally, a su