Re: [PATCH v1 1/1] pc-bios/s390-ccw: fix sclp_get_loadparm_ascii

2019-11-29 Thread Thomas Huth
On 29/11/2019 08.38, Christian Borntraeger wrote: > > > On 28.11.19 16:05, Peter Maydell wrote: >> On Thu, 28 Nov 2019 at 12:48, Christian Borntraeger >> wrote: >>> >>> >>> >>> On 28.11.19 13:45, Cornelia Huck wrote: On Thu, 28 Nov 2019 13:35:29 +0100 Christian Borntraeger wrote:

Re: [PATCH v1 1/1] pc-bios/s390-ccw: fix sclp_get_loadparm_ascii

2019-11-28 Thread Christian Borntraeger
On 28.11.19 16:05, Peter Maydell wrote: > On Thu, 28 Nov 2019 at 12:48, Christian Borntraeger > wrote: >> >> >> >> On 28.11.19 13:45, Cornelia Huck wrote: >>> On Thu, 28 Nov 2019 13:35:29 +0100 >>> Christian Borntraeger wrote: >>> Ack. Conny, I think this would be really nice

Re: [PATCH v1 1/1] pc-bios/s390-ccw: fix sclp_get_loadparm_ascii

2019-11-28 Thread Peter Maydell
On Thu, 28 Nov 2019 at 12:48, Christian Borntraeger wrote: > > > > On 28.11.19 13:45, Cornelia Huck wrote: > > On Thu, 28 Nov 2019 13:35:29 +0100 > > Christian Borntraeger wrote: > > > >> Ack. > >> > >> Conny, I think this would be really nice to have for 4.2 (together with a > >> bios rebuild)

Re: [PATCH v1 1/1] pc-bios/s390-ccw: fix sclp_get_loadparm_ascii

2019-11-28 Thread Christian Borntraeger
On 28.11.19 14:16, Cornelia Huck wrote: > On Thu, 28 Nov 2019 14:11:38 +0100 > Thomas Huth wrote: > >> On 28/11/2019 13.35, Christian Borntraeger wrote: >>> Ack. >>> >>> Conny, I think this would be really nice to have for 4.2 (together with a >>> bios rebuild) >>> as this fixes a

Re: [PATCH v1 1/1] pc-bios/s390-ccw: fix sclp_get_loadparm_ascii

2019-11-28 Thread Marc Hartmayer
On Thu, Nov 28, 2019 at 01:33 PM +0100, Claudio Imbrenda wrote: > The existing s390 bios gets the LOADPARM information from the system using > an SCLP call that specifies a buffer length too small to contain all the > output. > > The recent fixes in the SCLP code have exposed this bug, since now

Re: [PATCH v1 1/1] pc-bios/s390-ccw: fix sclp_get_loadparm_ascii

2019-11-28 Thread Cornelia Huck
On Thu, 28 Nov 2019 13:33:57 +0100 Claudio Imbrenda wrote: > The existing s390 bios gets the LOADPARM information from the system using > an SCLP call that specifies a buffer length too small to contain all the > output. > > The recent fixes in the SCLP code have exposed this bug, since now the

Re: [PATCH v1 1/1] pc-bios/s390-ccw: fix sclp_get_loadparm_ascii

2019-11-28 Thread Thomas Huth
On 28/11/2019 13.35, Christian Borntraeger wrote: Ack. Conny, I think this would be really nice to have for 4.2 (together with a bios rebuild) as this fixes a regression. Opinions? If we do another rc of 4.2, I think we definitely want this to be included, otherwise quite a bunch of things

Re: [PATCH v1 1/1] pc-bios/s390-ccw: fix sclp_get_loadparm_ascii

2019-11-28 Thread Cornelia Huck
On Thu, 28 Nov 2019 14:11:38 +0100 Thomas Huth wrote: > On 28/11/2019 13.35, Christian Borntraeger wrote: > > Ack. > > > > Conny, I think this would be really nice to have for 4.2 (together with a > > bios rebuild) > > as this fixes a regression. Opinions? > > If we do another rc of 4.2, I

Re: [PATCH v1 1/1] pc-bios/s390-ccw: fix sclp_get_loadparm_ascii

2019-11-28 Thread Cornelia Huck
On Thu, 28 Nov 2019 13:35:29 +0100 Christian Borntraeger wrote: > Ack. > > Conny, I think this would be really nice to have for 4.2 (together with a > bios rebuild) > as this fixes a regression. Opinions? I fear that this is a bit late for 4.2... but this should get a cc:stable. > > > >

Re: [PATCH v1 1/1] pc-bios/s390-ccw: fix sclp_get_loadparm_ascii

2019-11-28 Thread Christian Borntraeger
On 28.11.19 13:45, Cornelia Huck wrote: > On Thu, 28 Nov 2019 13:35:29 +0100 > Christian Borntraeger wrote: > >> Ack. >> >> Conny, I think this would be really nice to have for 4.2 (together with a >> bios rebuild) >> as this fixes a regression. Opinions? > > I fear that this is a bit late

Re: [PATCH v1 1/1] pc-bios/s390-ccw: fix sclp_get_loadparm_ascii

2019-11-28 Thread Claudio Imbrenda
On Thu, 28 Nov 2019 13:33:57 +0100 Claudio Imbrenda wrote: [...] > Signed-off-by: Claudio Imbrenda I forgot this: Reported-by: Marc Hartmayer [...] please add the reported-by when merging :)

Re: [PATCH v1 1/1] pc-bios/s390-ccw: fix sclp_get_loadparm_ascii

2019-11-28 Thread Janosch Frank
On 11/28/19 1:33 PM, Claudio Imbrenda wrote: > The existing s390 bios gets the LOADPARM information from the system using > an SCLP call that specifies a buffer length too small to contain all the > output. > > The recent fixes in the SCLP code have exposed this bug, since now the > SCLP call

Re: [PATCH v1 1/1] pc-bios/s390-ccw: fix sclp_get_loadparm_ascii

2019-11-28 Thread Christian Borntraeger
Ack. Conny, I think this would be really nice to have for 4.2 (together with a bios rebuild) as this fixes a regression. Opinions? On 28.11.19 13:33, Claudio Imbrenda wrote: > The existing s390 bios gets the LOADPARM information from the system using > an SCLP call that specifies a buffer

[PATCH v1 1/1] pc-bios/s390-ccw: fix sclp_get_loadparm_ascii

2019-11-28 Thread Claudio Imbrenda
The existing s390 bios gets the LOADPARM information from the system using an SCLP call that specifies a buffer length too small to contain all the output. The recent fixes in the SCLP code have exposed this bug, since now the SCLP call will return an error (as per architecture) instead of