Re: [PATCH v1 1/1] riscv: Pass RISCVHartArrayState by pointer

2021-01-19 Thread Eric Blake
On 1/17/21 10:52 AM, Philippe Mathieu-Daudé wrote: > On 1/16/21 11:38 PM, Alistair Francis wrote: >> On Sat, Jan 16, 2021 at 2:32 PM Philippe Mathieu-Daudé >> wrote: >>> >>> On 1/16/21 12:00 AM, Alistair Francis wrote: We were accidently passing RISCVHartArrayState by value instead of

Re: [PATCH v1 1/1] riscv: Pass RISCVHartArrayState by pointer

2021-01-18 Thread Richard Henderson
On 1/15/21 1:00 PM, Alistair Francis wrote: > +bool riscv_is_32bit(RISCVHartArrayState *harts) > { > -RISCVCPU hart = harts.harts[0]; > +RISCVCPU hart = harts->harts[0]; This is a large structure copy as well. > return riscv_cpu_is_32bit(); > } Better as >harts[0].env

Re: [PATCH v1 1/1] riscv: Pass RISCVHartArrayState by pointer

2021-01-17 Thread Philippe Mathieu-Daudé
On 1/16/21 11:38 PM, Alistair Francis wrote: > On Sat, Jan 16, 2021 at 2:32 PM Philippe Mathieu-Daudé > wrote: >> >> On 1/16/21 12:00 AM, Alistair Francis wrote: >>> We were accidently passing RISCVHartArrayState by value instead of >>> pointer. The type is 824 bytes long so let's correct that

Re: [PATCH v1 1/1] riscv: Pass RISCVHartArrayState by pointer

2021-01-16 Thread Alistair Francis
On Sat, Jan 16, 2021 at 2:32 PM Philippe Mathieu-Daudé wrote: > > On 1/16/21 12:00 AM, Alistair Francis wrote: > > We were accidently passing RISCVHartArrayState by value instead of > > pointer. The type is 824 bytes long so let's correct that and pass it by > > pointer instead. > > > > Fixes:

Re: [PATCH v1 1/1] riscv: Pass RISCVHartArrayState by pointer

2021-01-16 Thread Philippe Mathieu-Daudé
On 1/16/21 12:00 AM, Alistair Francis wrote: > We were accidently passing RISCVHartArrayState by value instead of > pointer. The type is 824 bytes long so let's correct that and pass it by > pointer instead. > > Fixes: Coverity CID 1438099 > Fixes: Coverity CID 1438100 > Fixes: Coverity CID

Re: [PATCH v1 1/1] riscv: Pass RISCVHartArrayState by pointer

2021-01-16 Thread Alistair Francis
On Fri, Jan 15, 2021 at 3:00 PM Alistair Francis wrote: > > We were accidently passing RISCVHartArrayState by value instead of > pointer. The type is 824 bytes long so let's correct that and pass it by > pointer instead. > > Fixes: Coverity CID 1438099 > Fixes: Coverity CID 1438100 > Fixes:

Re: [PATCH v1 1/1] riscv: Pass RISCVHartArrayState by pointer

2021-01-16 Thread Alistair Francis
On Sat, Jan 16, 2021 at 8:30 AM Bin Meng wrote: > > On Sat, Jan 16, 2021 at 7:00 AM Alistair Francis > wrote: > > > > We were accidently passing RISCVHartArrayState by value instead of > > pointer. The type is 824 bytes long so let's correct that and pass it by > > pointer instead. > > > >

Re: [PATCH v1 1/1] riscv: Pass RISCVHartArrayState by pointer

2021-01-16 Thread Bin Meng
On Sat, Jan 16, 2021 at 7:00 AM Alistair Francis wrote: > > We were accidently passing RISCVHartArrayState by value instead of > pointer. The type is 824 bytes long so let's correct that and pass it by > pointer instead. > > Fixes: Coverity CID 1438099 > Fixes: Coverity CID 1438100 > Fixes:

Re: [PATCH v1 1/1] riscv: Pass RISCVHartArrayState by pointer

2021-01-15 Thread Palmer Dabbelt
On Fri, 15 Jan 2021 15:00:27 PST (-0800), Alistair Francis wrote: We were accidently passing RISCVHartArrayState by value instead of pointer. The type is 824 bytes long so let's correct that and pass it by pointer instead. Fixes: Coverity CID 1438099 Fixes: Coverity CID 1438100 Fixes: Coverity

[PATCH v1 1/1] riscv: Pass RISCVHartArrayState by pointer

2021-01-15 Thread Alistair Francis
We were accidently passing RISCVHartArrayState by value instead of pointer. The type is 824 bytes long so let's correct that and pass it by pointer instead. Fixes: Coverity CID 1438099 Fixes: Coverity CID 1438100 Fixes: Coverity CID 1438101 Signed-off-by: Alistair Francis ---