Re: [PATCH v1 1/2] s390x/tcg: Implement Vector-Enhancements Facility 2 for s390x

2022-03-06 Thread David Miller
> Just use a little-endian load: MO_LE | es. > While we use MO_TE all over, it's no secret that it's always big-endian. > And everywhere else you do load then swap, or swap then store. This is not working as expected... I tried it in two places, both with a swap [removed] after and the tests fail

Re: [PATCH v1 1/2] s390x/tcg: Implement Vector-Enhancements Facility 2 for s390x

2022-03-03 Thread David Hildenbrand
On 03.03.22 19:01, David Miller wrote: > > Makes sense,  thanks for the quick reply. > Last question,  the patches can depend on others in the same set right? > IE:  all of the additions to insn-data.def in one, implementations in > separate patches. For bisectability, each patch should be self-c

Re: [PATCH v1 1/2] s390x/tcg: Implement Vector-Enhancements Facility 2 for s390x

2022-03-03 Thread David Miller
Makes sense, thanks for the quick reply. Last question, the patches can depend on others in the same set right? IE: all of the additions to insn-data.def in one, implementations in separate patches. Thanks - David Miller On Thu, Mar 3, 2022 at 12:42 PM Richard Henderson < richard.hender...@li

Re: [PATCH v1 1/2] s390x/tcg: Implement Vector-Enhancements Facility 2 for s390x

2022-03-03 Thread Richard Henderson
On 3/3/22 06:50, David Miller wrote: > Too many changes in one patch. > You need to split these into smaller, logical units. Can you give some guideline on that? IE: change to two,  the shifts and reversed loads into two patches or more on line count of each patch? Your best guide is line

Re: [PATCH v1 1/2] s390x/tcg: Implement Vector-Enhancements Facility 2 for s390x

2022-03-03 Thread David Miller
> Too many changes in one patch. > You need to split these into smaller, logical units. Can you give some guideline on that? IE: change to two, the shifts and reversed loads into two patches or more on line count of each patch? . > Tabs, and more later. The tabs should not happen at all, I disa

Re: [PATCH v1 1/2] s390x/tcg: Implement Vector-Enhancements Facility 2 for s390x

2022-03-03 Thread Richard Henderson
On 3/2/22 17:22, David Miller wrote: resolves: https://gitlab.com/qemu-project/qemu/-/issues/738 implements: VECTOR LOAD ELEMENTS REVERSED (VLER) VECTOR LOAD BYTE REVERSED ELEMENTS (VLBR) VECTOR LOAD BYTE REVERSED ELEMENT (VLEBRH, VLEBRF, VLEBRG) VECTOR LOAD BYTE

[PATCH v1 1/2] s390x/tcg: Implement Vector-Enhancements Facility 2 for s390x

2022-03-02 Thread David Miller
resolves: https://gitlab.com/qemu-project/qemu/-/issues/738 implements: VECTOR LOAD ELEMENTS REVERSED (VLER) VECTOR LOAD BYTE REVERSED ELEMENTS (VLBR) VECTOR LOAD BYTE REVERSED ELEMENT (VLEBRH, VLEBRF, VLEBRG) VECTOR LOAD BYTE REVERSED ELEMENT AND ZERO (VLLEBRZ) V