Re: [PATCH v11 09/10] virtio-gpu: Register capsets dynamically

2024-05-15 Thread Dmitry Osipenko
On 5/13/24 12:20, Akihiko Odaki wrote: ... >>   -int virtio_gpu_virgl_get_num_capsets(VirtIOGPU *g) >> +static void virtio_gpu_virgl_add_capset(GArray *capset_ids, uint32_t >> capset_id) >> +{ >> +    g_array_append_val(capset_ids, capset_id); >> +} > > Is it worthwhile to have a function for this

Re: [PATCH v11 09/10] virtio-gpu: Register capsets dynamically

2024-05-13 Thread Akihiko Odaki
On 2024/05/12 3:22, Dmitry Osipenko wrote: From: Pierre-Eric Pelloux-Prayer virtio_gpu_virgl_get_num_capsets will return "num_capsets", but we can't assume that capset_index 1 is always VIRGL2 once we'll support more capsets, like Venus and DRM capsets. Register capsets dynamically to avoid tha

[PATCH v11 09/10] virtio-gpu: Register capsets dynamically

2024-05-11 Thread Dmitry Osipenko
From: Pierre-Eric Pelloux-Prayer virtio_gpu_virgl_get_num_capsets will return "num_capsets", but we can't assume that capset_index 1 is always VIRGL2 once we'll support more capsets, like Venus and DRM capsets. Register capsets dynamically to avoid that problem. Signed-off-by: Pierre-Eric Pellou