On 6/10/24 06:38, Akihiko Odaki wrote:
> On 2024/06/10 4:02, Dmitry Osipenko wrote:
>> On 6/3/24 08:44, Akihiko Odaki wrote:
>>> On 2024/06/03 14:26, Dmitry Osipenko wrote:
On 6/2/24 08:34, Akihiko Odaki wrote:
>> +typedef enum {
>> + RS_START, /* starting state */
>> +
On 2024/06/10 4:02, Dmitry Osipenko wrote:
On 6/3/24 08:44, Akihiko Odaki wrote:
On 2024/06/03 14:26, Dmitry Osipenko wrote:
On 6/2/24 08:34, Akihiko Odaki wrote:
+typedef enum {
+ RS_START, /* starting state */
+ RS_INIT_FAILED, /* failed initialisation */
Is the distinction bet
On 6/4/24 17:21, Marc-André Lureau wrote:
>> @@ -65,13 +70,21 @@ static void virtio_gpu_gl_handle_ctrl(VirtIODevice
>> *vdev, VirtQueue *vq)
>> return;
>> }
>>
>> -if (!gl->renderer_inited) {
>> -virtio_gpu_virgl_init(g);
>> -gl->renderer_inited = true;
>> -}
>
On 6/3/24 08:44, Akihiko Odaki wrote:
> On 2024/06/03 14:26, Dmitry Osipenko wrote:
>> On 6/2/24 08:34, Akihiko Odaki wrote:
+typedef enum {
+ RS_START, /* starting state */
+ RS_INIT_FAILED, /* failed initialisation */
>>>
>>> Is the distinction between RS_START and RS_I
Hi
On Mon, May 27, 2024 at 7:03 AM Dmitry Osipenko <
dmitry.osipe...@collabora.com> wrote:
> virtio_gpu_virgl_init() may fail, leading to a further Qemu crash
> because Qemu assumes it never fails. Check virtio_gpu_virgl_init()
> return code and don't execute virtio commands on error. Failed
> vi
On 2024/06/03 14:26, Dmitry Osipenko wrote:
On 6/2/24 08:34, Akihiko Odaki wrote:
+typedef enum {
+ RS_START, /* starting state */
+ RS_INIT_FAILED, /* failed initialisation */
Is the distinction between RS_START and RS_INIT_FAILED really necessary?
The state stays in RS_INIT_FAI
On 6/2/24 08:34, Akihiko Odaki wrote:
>> +typedef enum {
>> + RS_START, /* starting state */
>> + RS_INIT_FAILED, /* failed initialisation */
>
> Is the distinction between RS_START and RS_INIT_FAILED really necessary?
The state stays in RS_INIT_FAILED once was failed until virtio-gpu
On 2024/05/27 12:02, Dmitry Osipenko wrote:
virtio_gpu_virgl_init() may fail, leading to a further Qemu crash
because Qemu assumes it never fails. Check virtio_gpu_virgl_init()
return code and don't execute virtio commands on error. Failed
virtio_gpu_virgl_init() will result in a timed out virtio
virtio_gpu_virgl_init() may fail, leading to a further Qemu crash
because Qemu assumes it never fails. Check virtio_gpu_virgl_init()
return code and don't execute virtio commands on error. Failed
virtio_gpu_virgl_init() will result in a timed out virtio commands
for a guest OS.
Signed-off-by: Dmit
