Re: [PATCH v2 09/12] hw/arm/virt: spe: Add SPE fdt binding for virt machine

2020-09-09 Thread Haibo Xu
On Wed, 9 Sep 2020 at 17:34, Andrew Jones wrote: > > On Wed, Sep 09, 2020 at 03:51:14PM +0800, Haibo Xu wrote: > > > > + > > > > +if (spe) { > > > > +assert(ARM_CPU(cpu)->has_spe == ON_OFF_AUTO_ON); > > > > +if (kvm_irqchip_in_kernel()) { > > > > +

Re: [PATCH v2 09/12] hw/arm/virt: spe: Add SPE fdt binding for virt machine

2020-09-09 Thread Andrew Jones
On Wed, Sep 09, 2020 at 03:51:14PM +0800, Haibo Xu wrote: > > > + > > > +if (spe) { > > > +assert(ARM_CPU(cpu)->has_spe == ON_OFF_AUTO_ON); > > > +if (kvm_irqchip_in_kernel()) { > > > +kvm_arm_spe_set_irq(cpu, PPI(VIRTUAL_SPE_IRQ)); >

Re: [PATCH v2 09/12] hw/arm/virt: spe: Add SPE fdt binding for virt machine

2020-09-09 Thread Haibo Xu
On Tue, 8 Sep 2020 at 19:16, Andrew Jones wrote: > > > This patch does much more than the summary "hw/arm/virt: spe: Add SPE fdt > binding for virt machine" says it does. Please revise the summary. > Will revise it in v3. Thanks, Haibo > On Tue, Sep 08, 2020 at 08:13:27AM +, Haibo Xu wrote:

Re: [PATCH v2 09/12] hw/arm/virt: spe: Add SPE fdt binding for virt machine

2020-09-08 Thread Andrew Jones
This patch does much more than the summary "hw/arm/virt: spe: Add SPE fdt binding for virt machine" says it does. Please revise the summary. On Tue, Sep 08, 2020 at 08:13:27AM +, Haibo Xu wrote: > Add a virtual SPE device for virt machine while using > PPI 5 for SPE overflow interrupt number

[PATCH v2 09/12] hw/arm/virt: spe: Add SPE fdt binding for virt machine

2020-09-08 Thread Haibo Xu
Add a virtual SPE device for virt machine while using PPI 5 for SPE overflow interrupt number which has already selected in kvmtool. Signed-off-by: Haibo Xu --- hw/arm/virt-acpi-build.c| 3 +++ hw/arm/virt.c | 43 - include/hw/acpi/acpi-defs