Re: [PATCH v2 09/13] block/qcow2-bitmap: improve qcow2_load_dirty_bitmaps() interface

2020-09-18 Thread Greg Kurz
On Thu, 17 Sep 2020 22:55:15 +0300 Vladimir Sementsov-Ogievskiy wrote: > It's recommended for bool functions with errp to return true on success > and false on failure. Non-standard interfaces don't help to understand > the code. The change is also needed to reduce error propagation. > >

Re: [PATCH v2 09/13] block/qcow2-bitmap: improve qcow2_load_dirty_bitmaps() interface

2020-09-18 Thread Vladimir Sementsov-Ogievskiy
18.09.2020 17:54, Alberto Garcia wrote: On Thu 17 Sep 2020 09:55:15 PM CEST, Vladimir Sementsov-Ogievskiy wrote: It's recommended for bool functions with errp to return true on success and false on failure. Non-standard interfaces don't help to understand the code. The change is also needed to

Re: [PATCH v2 09/13] block/qcow2-bitmap: improve qcow2_load_dirty_bitmaps() interface

2020-09-18 Thread Alberto Garcia
On Thu 17 Sep 2020 09:55:15 PM CEST, Vladimir Sementsov-Ogievskiy wrote: > It's recommended for bool functions with errp to return true on success > and false on failure. Non-standard interfaces don't help to understand > the code. The change is also needed to reduce error propagation. > >

[PATCH v2 09/13] block/qcow2-bitmap: improve qcow2_load_dirty_bitmaps() interface

2020-09-17 Thread Vladimir Sementsov-Ogievskiy
It's recommended for bool functions with errp to return true on success and false on failure. Non-standard interfaces don't help to understand the code. The change is also needed to reduce error propagation. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/qcow2.h| 3 ++-