Re: [PATCH v2 2/2] e1000e: fix link state on resume

2024-03-08 Thread Laurent Vivier
On 3/8/24 09:09, Jason Wang wrote: On Tue, Mar 5, 2024 at 6:07 PM Laurent Vivier wrote: On 2/1/24 06:45, Jason Wang wrote: On Wed, Jan 24, 2024 at 6:40 PM Laurent Vivier wrote: On resume e1000e_vm_state_change() always calls e1000e_autoneg_resume() that sets link_down to false, and thus

Re: [PATCH v2 2/2] e1000e: fix link state on resume

2024-03-08 Thread Jason Wang
On Tue, Mar 5, 2024 at 6:07 PM Laurent Vivier wrote: > > On 2/1/24 06:45, Jason Wang wrote: > > On Wed, Jan 24, 2024 at 6:40 PM Laurent Vivier wrote: > >> > >> On resume e1000e_vm_state_change() always calls e1000e_autoneg_resume() > >> that sets link_down to false, and thus activates the link

Re: [PATCH v2 2/2] e1000e: fix link state on resume

2024-03-05 Thread Jason Wang
Hi Laurent: On Tue, Mar 5, 2024 at 6:07 PM Laurent Vivier wrote: > > On 2/1/24 06:45, Jason Wang wrote: > > On Wed, Jan 24, 2024 at 6:40 PM Laurent Vivier wrote: > >> > >> On resume e1000e_vm_state_change() always calls e1000e_autoneg_resume() > >> that sets link_down to false, and thus

Re: [PATCH v2 2/2] e1000e: fix link state on resume

2024-03-05 Thread Laurent Vivier
On 2/1/24 06:45, Jason Wang wrote: On Wed, Jan 24, 2024 at 6:40 PM Laurent Vivier wrote: On resume e1000e_vm_state_change() always calls e1000e_autoneg_resume() that sets link_down to false, and thus activates the link even if we have disabled it. The problem can be reproduced starting qemu

Re: [PATCH v2 2/2] e1000e: fix link state on resume

2024-01-31 Thread Jason Wang
On Wed, Jan 24, 2024 at 6:40 PM Laurent Vivier wrote: > > On resume e1000e_vm_state_change() always calls e1000e_autoneg_resume() > that sets link_down to false, and thus activates the link even > if we have disabled it. > > The problem can be reproduced starting qemu in paused state (-S) and >

Re: [PATCH v2 2/2] e1000e: fix link state on resume

2024-01-28 Thread Akihiko Odaki
On 2024/01/24 19:40, Laurent Vivier wrote: On resume e1000e_vm_state_change() always calls e1000e_autoneg_resume() that sets link_down to false, and thus activates the link even if we have disabled it. The problem can be reproduced starting qemu in paused state (-S) and then set the link to

[PATCH v2 2/2] e1000e: fix link state on resume

2024-01-24 Thread Laurent Vivier
On resume e1000e_vm_state_change() always calls e1000e_autoneg_resume() that sets link_down to false, and thus activates the link even if we have disabled it. The problem can be reproduced starting qemu in paused state (-S) and then set the link to down. When we resume the machine the link