Re: [PATCH v2 2/3] Add zero-copy-copied migration stat

2022-07-04 Thread Markus Armbruster
Leonardo Brás writes: > Thanks Daniel, Markus and Dave for the feedback! > > On Mon, 2022-07-04 at 14:14 +0100, Daniel P. Berrangé wrote: >> On Mon, Jul 04, 2022 at 02:59:50PM +0200, Markus Armbruster wrote: >> > Daniel P. Berrangé writes: >> > >> > > On Mon, Jul 04, 2022 at 02:04:41PM +0200, M

Re: [PATCH v2 2/3] Add zero-copy-copied migration stat

2022-07-04 Thread Leonardo Brás
Thanks Daniel, Markus and Dave for the feedback! On Mon, 2022-07-04 at 14:14 +0100, Daniel P. Berrangé wrote: > On Mon, Jul 04, 2022 at 02:59:50PM +0200, Markus Armbruster wrote: > > Daniel P. Berrangé writes: > > > > > On Mon, Jul 04, 2022 at 02:04:41PM +0200, Markus Armbruster wrote: > > [...

Re: [PATCH v2 2/3] Add zero-copy-copied migration stat

2022-07-04 Thread Daniel P . Berrangé
On Mon, Jul 04, 2022 at 02:59:50PM +0200, Markus Armbruster wrote: > Daniel P. Berrangé writes: > > > On Mon, Jul 04, 2022 at 02:04:41PM +0200, Markus Armbruster wrote: > > [...] > > >> Please rephrase the documentation of @zero-copy-copied in terms of > >> @dirty-sync-count. Here's my attempt

Re: [PATCH v2 2/3] Add zero-copy-copied migration stat

2022-07-04 Thread Markus Armbruster
Daniel P. Berrangé writes: > On Mon, Jul 04, 2022 at 02:04:41PM +0200, Markus Armbruster wrote: [...] >> Please rephrase the documentation of @zero-copy-copied in terms of >> @dirty-sync-count. Here's my attempt. >> >> # @zero-copy-copied: Number of times dirty RAM synchronization could not >

Re: [PATCH v2 2/3] Add zero-copy-copied migration stat

2022-07-04 Thread Daniel P . Berrangé
On Mon, Jul 04, 2022 at 02:04:41PM +0200, Markus Armbruster wrote: > "Dr. David Alan Gilbert" writes: > > > * Daniel P. Berrangé (berra...@redhat.com) wrote: > >> On Mon, Jul 04, 2022 at 08:18:54AM +0200, Markus Armbruster wrote: > >> > Leonardo Bras writes: > >> > > >> > > Signed-off-by: Leona

Re: [PATCH v2 2/3] Add zero-copy-copied migration stat

2022-07-04 Thread Markus Armbruster
"Dr. David Alan Gilbert" writes: > * Daniel P. Berrangé (berra...@redhat.com) wrote: >> On Mon, Jul 04, 2022 at 08:18:54AM +0200, Markus Armbruster wrote: >> > Leonardo Bras writes: >> > >> > > Signed-off-by: Leonardo Bras >> > > --- >> > > qapi/migration.json | 5 - >> > > migration/mi

Re: [PATCH v2 2/3] Add zero-copy-copied migration stat

2022-07-04 Thread Dr. David Alan Gilbert
* Daniel P. Berrangé (berra...@redhat.com) wrote: > On Mon, Jul 04, 2022 at 08:18:54AM +0200, Markus Armbruster wrote: > > Leonardo Bras writes: > > > > > Signed-off-by: Leonardo Bras > > > --- > > > qapi/migration.json | 5 - > > > migration/migration.c | 1 + > > > monitor/hmp-cmds.c

Re: [PATCH v2 2/3] Add zero-copy-copied migration stat

2022-07-04 Thread Markus Armbruster
Daniel P. Berrangé writes: > On Mon, Jul 04, 2022 at 08:18:54AM +0200, Markus Armbruster wrote: >> Leonardo Bras writes: >> >> > Signed-off-by: Leonardo Bras >> > --- >> > qapi/migration.json | 5 - >> > migration/migration.c | 1 + >> > monitor/hmp-cmds.c| 4 >> > 3 files chan

Re: [PATCH v2 2/3] Add zero-copy-copied migration stat

2022-07-04 Thread Daniel P . Berrangé
On Mon, Jul 04, 2022 at 08:18:54AM +0200, Markus Armbruster wrote: > Leonardo Bras writes: > > > Signed-off-by: Leonardo Bras > > --- > > qapi/migration.json | 5 - > > migration/migration.c | 1 + > > monitor/hmp-cmds.c| 4 > > 3 files changed, 9 insertions(+), 1 deletion(-) > >

Re: [PATCH v2 2/3] Add zero-copy-copied migration stat

2022-07-03 Thread Markus Armbruster
Leonardo Bras writes: > Signed-off-by: Leonardo Bras > --- > qapi/migration.json | 5 - > migration/migration.c | 1 + > monitor/hmp-cmds.c| 4 > 3 files changed, 9 insertions(+), 1 deletion(-) > > diff --git a/qapi/migration.json b/qapi/migration.json > index 7102e474a6..925f009

[PATCH v2 2/3] Add zero-copy-copied migration stat

2022-07-01 Thread Leonardo Bras
Signed-off-by: Leonardo Bras --- qapi/migration.json | 5 - migration/migration.c | 1 + monitor/hmp-cmds.c| 4 3 files changed, 9 insertions(+), 1 deletion(-) diff --git a/qapi/migration.json b/qapi/migration.json index 7102e474a6..925f009868 100644 --- a/qapi/migration.json +++