Re: [PATCH v2 3/3] hw/ide: Include 'ide_internal.h' from current path

2024-02-26 Thread BALATON Zoltan
On Mon, 26 Feb 2024, Philippe Mathieu-Daudé wrote: On 26/2/24 11:50, BALATON Zoltan wrote: On Mon, 26 Feb 2024, Philippe Mathieu-Daudé wrote: On 26/2/24 08:40, Markus Armbruster wrote: BALATON Zoltan writes: On Sun, 25 Feb 2024, Philippe Mathieu-Daudé wrote: Rename "internal.h" as

Re: [PATCH v2 3/3] hw/ide: Include 'ide_internal.h' from current path

2024-02-26 Thread Philippe Mathieu-Daudé
On 26/2/24 11:50, BALATON Zoltan wrote: On Mon, 26 Feb 2024, Philippe Mathieu-Daudé wrote: On 26/2/24 08:40, Markus Armbruster wrote: BALATON Zoltan writes: On Sun, 25 Feb 2024, Philippe Mathieu-Daudé wrote: Rename "internal.h" as "ide_internal.h", and include Is there a convention about

Re: [PATCH v2 3/3] hw/ide: Include 'ide_internal.h' from current path

2024-02-26 Thread BALATON Zoltan
On Mon, 26 Feb 2024, Philippe Mathieu-Daudé wrote: On 26/2/24 09:00, Philippe Mathieu-Daudé wrote: On 26/2/24 08:40, Markus Armbruster wrote: BALATON Zoltan writes: On Sun, 25 Feb 2024, Philippe Mathieu-Daudé wrote: Rename "internal.h" as "ide_internal.h", and include Is there a

Re: [PATCH v2 3/3] hw/ide: Include 'ide_internal.h' from current path

2024-02-26 Thread BALATON Zoltan
On Mon, 26 Feb 2024, Philippe Mathieu-Daudé wrote: On 26/2/24 08:40, Markus Armbruster wrote: BALATON Zoltan writes: On Sun, 25 Feb 2024, Philippe Mathieu-Daudé wrote: Rename "internal.h" as "ide_internal.h", and include Is there a convention about using underscore or dash in file names?

Re: [PATCH v2 3/3] hw/ide: Include 'ide_internal.h' from current path

2024-02-26 Thread Philippe Mathieu-Daudé
On 26/2/24 09:00, Philippe Mathieu-Daudé wrote: On 26/2/24 08:40, Markus Armbruster wrote: BALATON Zoltan writes: On Sun, 25 Feb 2024, Philippe Mathieu-Daudé wrote: Rename "internal.h" as "ide_internal.h", and include Is there a convention about using underscore or dash in file names?

Re: [PATCH v2 3/3] hw/ide: Include 'ide_internal.h' from current path

2024-02-26 Thread Philippe Mathieu-Daudé
On 26/2/24 08:40, Markus Armbruster wrote: BALATON Zoltan writes: On Sun, 25 Feb 2024, Philippe Mathieu-Daudé wrote: Rename "internal.h" as "ide_internal.h", and include Is there a convention about using underscore or dash in file names? The headers Thomas added are using - as well as

Re: [PATCH v2 3/3] hw/ide: Include 'ide_internal.h' from current path

2024-02-25 Thread Markus Armbruster
BALATON Zoltan writes: > On Sun, 25 Feb 2024, Philippe Mathieu-Daudé wrote: >> Rename "internal.h" as "ide_internal.h", and include > > Is there a convention about using underscore or dash in file names? The > headers Thomas added are using - as well as ahci-allwinner.c, only > ahci_internal.h

Re: [PATCH v2 3/3] hw/ide: Include 'ide_internal.h' from current path

2024-02-25 Thread BALATON Zoltan
On Sun, 25 Feb 2024, Philippe Mathieu-Daudé wrote: Rename "internal.h" as "ide_internal.h", and include Is there a convention about using underscore or dash in file names? The headers Thomas added are using - as well as ahci-allwinner.c, only ahci_internal.h has _ (but there are others

[PATCH v2 3/3] hw/ide: Include 'ide_internal.h' from current path

2024-02-25 Thread Philippe Mathieu-Daudé
Rename "internal.h" as "ide_internal.h", and include it via its relative local path, instead of absolute to the project root path. Mechanical patch doing: $ sed -i -e 's#hw/ide/internal.h#ide_internal.h#' \ $(git grep -l hw/ide/internal) $ git mv hw/ide/internal.h