Re: [PATCH v2 3/5] linux-user/i386: Emulate x86_64 vsyscalls

2020-01-21 Thread Paolo Bonzini
On 21/01/20 17:15, Alex Bennée wrote: > > Richard Henderson writes: > >> On 1/21/20 12:13 AM, Alex Bennée wrote: >>> >>> Richard Henderson writes: >>> On 1/20/20 1:48 AM, Alex Bennée wrote: >> +default: >> +sigsegv: > > this label looks a little extraneous. > >>

Re: [PATCH v2 3/5] linux-user/i386: Emulate x86_64 vsyscalls

2020-01-21 Thread Alex Bennée
Richard Henderson writes: > On 1/21/20 12:13 AM, Alex Bennée wrote: >> >> Richard Henderson writes: >> >>> On 1/20/20 1:48 AM, Alex Bennée wrote: > +default: > +sigsegv: this label looks a little extraneous. Otherwise: Reviewed-by: Alex Bennée >

Re: [PATCH v2 3/5] linux-user/i386: Emulate x86_64 vsyscalls

2020-01-21 Thread Richard Henderson
On 1/21/20 12:13 AM, Alex Bennée wrote: > > Richard Henderson writes: > >> On 1/20/20 1:48 AM, Alex Bennée wrote: +default: +sigsegv: >>> >>> this label looks a little extraneous. >>> >>> Otherwise: >>> >>> Reviewed-by: Alex Bennée >>> >> >> Look a little further down: >> >>>

Re: [PATCH v2 3/5] linux-user/i386: Emulate x86_64 vsyscalls

2020-01-21 Thread Alex Bennée
Richard Henderson writes: > On 1/20/20 1:48 AM, Alex Bennée wrote: >>> +default: >>> +sigsegv: >> >> this label looks a little extraneous. >> >> Otherwise: >> >> Reviewed-by: Alex Bennée >> > > Look a little further down: > >> +default: >> +sigsegv: >> +/* Like forc

Re: [PATCH v2 3/5] linux-user/i386: Emulate x86_64 vsyscalls

2020-01-20 Thread Richard Henderson
On 1/20/20 1:48 AM, Alex Bennée wrote: >> +default: >> +sigsegv: > > this label looks a little extraneous. > > Otherwise: > > Reviewed-by: Alex Bennée > Look a little further down: > +default: > +sigsegv: > +/* Like force_sig(SIGSEGV). */ > +gen_signal(env, T

Re: [PATCH v2 3/5] linux-user/i386: Emulate x86_64 vsyscalls

2020-01-20 Thread Alex Bennée
Richard Henderson writes: > Notice the magic page during translate, much like we already > do for the arm32 commpage. At runtime, raise an exception to > return cpu_loop for emulation. > > Reviewed-by: Paolo Bonzini > Signed-off-by: Richard Henderson > --- > target/i386/cpu.h | 1

[PATCH v2 3/5] linux-user/i386: Emulate x86_64 vsyscalls

2020-01-16 Thread Richard Henderson
Notice the magic page during translate, much like we already do for the arm32 commpage. At runtime, raise an exception to return cpu_loop for emulation. Reviewed-by: Paolo Bonzini Signed-off-by: Richard Henderson --- target/i386/cpu.h | 1 + linux-user/i386/cpu_loop.c | 105