Re: [PATCH v3 03/10] qemu/atomic: Add aligned_{int64,uint64}_t types

2021-07-20 Thread Richard Henderson
On 7/19/21 2:39 AM, Peter Maydell wrote: This cast is OK, but it took me a while to verify that: * we check that 'addr' is 8-aligned further up in this function * we check that guest_base is at least page-aligned in probe_guest_base(), and there's no way to avoid that function

Re: [PATCH v3 03/10] qemu/atomic: Add aligned_{int64,uint64}_t types

2021-07-19 Thread Peter Maydell
On Sat, 17 Jul 2021 at 20:24, Richard Henderson wrote: > > Use it to avoid some clang-12 -Watomic-alignment errors, > forcing some structures to be aligned and as a pointer when > we have ensured that the address is aligned. > > Reviewed-by: Philippe Mathieu-Daudé > Signed-off-by: Richard

[PATCH v3 03/10] qemu/atomic: Add aligned_{int64,uint64}_t types

2021-07-17 Thread Richard Henderson
Use it to avoid some clang-12 -Watomic-alignment errors, forcing some structures to be aligned and as a pointer when we have ensured that the address is aligned. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- accel/tcg/atomic_template.h | 4 ++--