Re: [PATCH v3 03/17] migration: Block migration comment or code is wrong

2022-11-20 Thread Avihai Horon
Ping. On 10/11/2022 15:38, Avihai Horon wrote: On 08/11/2022 20:36, Vladimir Sementsov-Ogievskiy wrote: External email: Use caution opening links or attachments On 11/3/22 19:16, Avihai Horon wrote: From: Juan Quintela And it appears that what is wrong is the code. During bulk stage we ne

Re: [PATCH v3 03/17] migration: Block migration comment or code is wrong

2022-11-10 Thread Avihai Horon
On 08/11/2022 20:36, Vladimir Sementsov-Ogievskiy wrote: External email: Use caution opening links or attachments On 11/3/22 19:16, Avihai Horon wrote: From: Juan Quintela And it appears that what is wrong is the code. During bulk stage we need to make sure that some block is dirty, but no

Re: [PATCH v3 03/17] migration: Block migration comment or code is wrong

2022-11-08 Thread Vladimir Sementsov-Ogievskiy
On 11/8/22 21:36, Vladimir Sementsov-Ogievskiy wrote: On 11/3/22 19:16, Avihai Horon wrote: From: Juan Quintela And it appears that what is wrong is the code. During bulk stage we need to make sure that some block is dirty, but no games with max_size at all. :) That made me interested in, wh

Re: [PATCH v3 03/17] migration: Block migration comment or code is wrong

2022-11-08 Thread Vladimir Sementsov-Ogievskiy
On 11/3/22 19:16, Avihai Horon wrote: From: Juan Quintela And it appears that what is wrong is the code. During bulk stage we need to make sure that some block is dirty, but no games with max_size at all. :) That made me interested in, why we need this one block, so I decided to search throu

[PATCH v3 03/17] migration: Block migration comment or code is wrong

2022-11-03 Thread Avihai Horon
From: Juan Quintela And it appears that what is wrong is the code. During bulk stage we need to make sure that some block is dirty, but no games with max_size at all. Signed-off-by: Juan Quintela Reviewed-by: Stefan Hajnoczi --- migration/block.c | 4 ++-- 1 file changed, 2 insertions(+), 2 d