Re: [PATCH v3 2/2] hw/char: sifive_uart: Print uart characters async

2024-09-09 Thread Philippe Mathieu-Daudé
Hi Alistair, On 9/9/24 04:13, Alistair Francis wrote: The current approach of using qemu_chr_fe_write() and ignoring the return values results in dropped characters [1]. Let's update the SiFive UART to use a async sifive_uart_xmit() function to transmit the characters and apply back pressure to

Re: [PATCH v3 2/2] hw/char: sifive_uart: Print uart characters async

2024-09-09 Thread Philippe Mathieu-Daudé
Hi Alistair, On 9/9/24 04:13, Alistair Francis wrote: The current approach of using qemu_chr_fe_write() and ignoring the return values results in dropped characters [1]. Let's update the SiFive UART to use a async sifive_uart_xmit() function to transmit the characters and apply back pressure to

Re: [PATCH v3 2/2] hw/char: sifive_uart: Print uart characters async

2024-09-09 Thread Daniel Henrique Barboza
On 9/8/24 11:13 PM, Alistair Francis wrote: The current approach of using qemu_chr_fe_write() and ignoring the return values results in dropped characters [1]. Let's update the SiFive UART to use a async sifive_uart_xmit() function to transmit the characters and apply back pressure to the gue

[PATCH v3 2/2] hw/char: sifive_uart: Print uart characters async

2024-09-08 Thread Alistair Francis
The current approach of using qemu_chr_fe_write() and ignoring the return values results in dropped characters [1]. Let's update the SiFive UART to use a async sifive_uart_xmit() function to transmit the characters and apply back pressure to the guest with the SIFIVE_UART_TXFIFO_FULL status. This