Re: [PATCH v3 21/22] qom/object: fix -Werror=maybe-uninitialized

Marc-André Lureau writes: > Hi > > On Wed, Oct 2, 2024 at 10:21 AM Markus Armbruster wrote: [...] >> Two ways to fix: >> >> 1. Find all callers that don't, and fix them. Your first hunk is then >>superfluous. Your second hunk fixes the one you already found. >> > > Imho, that's not a goo

Re: [PATCH v3 21/22] qom/object: fix -Werror=maybe-uninitialized

On 01.10.24 18:22, Marc-André Lureau wrote: Hi Vladimir On Tue, Oct 1, 2024 at 6:06 PM Vladimir Sementsov-Ogievskiy mailto:vsement...@yandex-team.ru>> wrote: On 30.09.24 11:14, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau mailto:mar

Re: [PATCH v3 21/22] qom/object: fix -Werror=maybe-uninitialized

Hi On Wed, Oct 2, 2024 at 10:21 AM Markus Armbruster wrote: > > marcandre.lur...@redhat.com writes: > > > From: Marc-André Lureau > > > > object_resolve_path_type() didn't always set *ambiguousp. > > > > Signed-off-by: Marc-André Lureau > > Fixes: 81c48dd79655 (hw/i386/acpi: Add object_resolve_

Re: [PATCH v3 21/22] qom/object: fix -Werror=maybe-uninitialized

marcandre.lur...@redhat.com writes: > From: Marc-André Lureau > > object_resolve_path_type() didn't always set *ambiguousp. > > Signed-off-by: Marc-André Lureau Fixes: 81c48dd79655 (hw/i386/acpi: Add object_resolve_type_unambiguous to improve modularity) > --- > qom/object.c | 5 - > 1 f

Re: [PATCH v3 21/22] qom/object: fix -Werror=maybe-uninitialized

Hi Vladimir On Tue, Oct 1, 2024 at 6:06 PM Vladimir Sementsov-Ogievskiy < vsement...@yandex-team.ru> wrote: > On 30.09.24 11:14, marcandre.lur...@redhat.com wrote: > > From: Marc-André Lureau > > > > object_resolve_path_type() didn't always set *ambiguousp. > > > > Signed-off-by: Marc-André Lure

Re: [PATCH v3 21/22] qom/object: fix -Werror=maybe-uninitialized

On 30.09.24 11:14, marcandre.lur...@redhat.com wrote: From: Marc-André Lureau object_resolve_path_type() didn't always set *ambiguousp. Signed-off-by: Marc-André Lureau --- qom/object.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/qom/object.c b/qom/object.c inde

[PATCH v3 21/22] qom/object: fix -Werror=maybe-uninitialized

From: Marc-André Lureau object_resolve_path_type() didn't always set *ambiguousp. Signed-off-by: Marc-André Lureau --- qom/object.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/qom/object.c b/qom/object.c index 28c5b66eab..bdc8a2c666 100644 --- a/qom/object.c +++ b/q