Re: [PATCH v3 4/7] migration/dirtyrate: add per-vcpu option for calc-dirty-rate

2021-06-07 Thread Peter Xu
On Tue, Jun 08, 2021 at 12:16:03AM +0800, Hyman Huang wrote: [...] > > Actually I'm also wondering whether dirty log could be anything useful here > > in > > the future as a 3rd mode (then the "*mode" idea should be more useful if > > so), > > basically for old kernels where dirty ring is not t

Re: [PATCH v3 4/7] migration/dirtyrate: add per-vcpu option for calc-dirty-rate

2021-06-07 Thread Hyman Huang
在 2021/6/7 23:46, Peter Xu 写道: On Mon, Jun 07, 2021 at 09:12:36AM +0800, huang...@chinatelecom.cn wrote: @@ -1751,7 +1770,9 @@ 'status': 'DirtyRateStatus', 'start-time': 'int64', 'calc-time': 'int64', - 'sample-pages': 'uint64'} } + '

Re: [PATCH v3 4/7] migration/dirtyrate: add per-vcpu option for calc-dirty-rate

2021-06-07 Thread Peter Xu
On Mon, Jun 07, 2021 at 09:12:36AM +0800, huang...@chinatelecom.cn wrote: > @@ -1751,7 +1770,9 @@ > 'status': 'DirtyRateStatus', > 'start-time': 'int64', > 'calc-time': 'int64', > - 'sample-pages': 'uint64'} } > + '*sample-pages': 'uint64', >

[PATCH v3 4/7] migration/dirtyrate: add per-vcpu option for calc-dirty-rate

2021-06-06 Thread huangy81
From: Hyman Huang(黄勇) calculate dirtyrate for each vcpu if vcpu is true, add the dirtyrate of each vcpu to the return value also. Signed-off-by: Hyman Huang(黄勇) --- migration/dirtyrate.c | 45 ++- migration/dirtyrate.h | 1 + qapi/migration.json | 29