Re: [PATCH v4 3/3] multifd: Implement zerocopy write in multifd migration (multifd-zerocopy)

2022-04-13 Thread Leonardo Bras Soares Passos
Hello Juan, Sorry to go back that early in discussion, but I was reviewing for v9 and I am not sure If I am unable to recall the reason, or I missed an argument here. Could you please help me with this? On Tue, Nov 2, 2021 at 9:32 AM Juan Quintela wrote: > > Leonardo Bras wrote: > > Implement z

Re: [PATCH v4 3/3] multifd: Implement zerocopy write in multifd migration (multifd-zerocopy)

2021-11-03 Thread Leonardo Bras Soares Passos
On Wed, Nov 3, 2021 at 8:24 PM Juan Quintela wrote: > > Leonardo Bras Soares Passos wrote: > > Hello Juan, > > hi > > > Current multifd's sendmsg() will block until all data is sent, is that > > correct? > > > > If that's the case, and supposing the network driver supports > > multiqueue, maybe

Re: [PATCH v4 3/3] multifd: Implement zerocopy write in multifd migration (multifd-zerocopy)

2021-11-03 Thread Juan Quintela
Leonardo Bras Soares Passos wrote: > Hello Juan, hi > Current multifd's sendmsg() will block until all data is sent, is that > correct? > > If that's the case, and supposing the network driver supports > multiqueue, maybe there is a small chance for this to happen. > I will add the flush at the

Re: [PATCH v4 3/3] multifd: Implement zerocopy write in multifd migration (multifd-zerocopy)

2021-11-03 Thread Leonardo Bras Soares Passos
Hello Juan, On Tue, Nov 2, 2021 at 9:32 AM Juan Quintela wrote: > > Leonardo Bras wrote: > > Implement zerocopy on nocomp_send_write(), by making use of QIOChannel > > zerocopy interface. > > > > Change multifd_send_sync_main() so it can distinguish the last sync from > > the setup and per-itera

Re: [PATCH v4 3/3] multifd: Implement zerocopy write in multifd migration (multifd-zerocopy)

2021-11-02 Thread Juan Quintela
Leonardo Bras wrote: > Implement zerocopy on nocomp_send_write(), by making use of QIOChannel > zerocopy interface. > > Change multifd_send_sync_main() so it can distinguish the last sync from > the setup and per-iteration ones, so a flush_zerocopy() can be called > at the last sync in order to ma

Re: [PATCH v4 3/3] multifd: Implement zerocopy write in multifd migration (multifd-zerocopy)

2021-10-27 Thread Leonardo Bras Soares Passos
On Thu, Oct 28, 2021 at 1:30 AM Markus Armbruster wrote: > > Leonardo Bras Soares Passos writes: > > [...] > > >> The general argument for having QAPI schema 'if' mirror the C > >> implementation's #if is introspection. Let me explain why that matters. > >> > >> Consider a management application

Re: [PATCH v4 3/3] multifd: Implement zerocopy write in multifd migration (multifd-zerocopy)

2021-10-27 Thread Markus Armbruster
Leonardo Bras Soares Passos writes: [...] >> The general argument for having QAPI schema 'if' mirror the C >> implementation's #if is introspection. Let me explain why that matters. >> >> Consider a management application that supports a range of QEMU >> versions, say 5.0 to 6.2. Say it wants

Re: [PATCH v4 3/3] multifd: Implement zerocopy write in multifd migration (multifd-zerocopy)

2021-10-27 Thread Leonardo Bras Soares Passos
Hello Markus! (comments at the bottom) On Tue, Oct 12, 2021 at 2:54 AM Markus Armbruster wrote: > > Leonardo Bras Soares Passos writes: > > > Hello Eric, > > > > On Mon, Oct 11, 2021 at 4:32 PM Eric Blake wrote: > >> > >> On Sat, Oct 09, 2021 at 04:56:13AM -0300, Leonardo Bras wrote: > >> > Imp

Re: [PATCH v4 3/3] multifd: Implement zerocopy write in multifd migration (multifd-zerocopy)

2021-10-27 Thread Peter Xu
On Wed, Oct 27, 2021 at 03:47:18AM -0300, Leonardo Bras Soares Passos wrote: > On Wed, Oct 13, 2021 at 3:24 AM Peter Xu wrote: > > > > On Sat, Oct 09, 2021 at 04:56:13AM -0300, Leonardo Bras wrote: > > > diff --git a/qapi/migration.json b/qapi/migration.json > > > index 88f07baedd..c4890cbb54 1006

Re: [PATCH v4 3/3] multifd: Implement zerocopy write in multifd migration (multifd-zerocopy)

2021-10-26 Thread Leonardo Bras Soares Passos
On Wed, Oct 13, 2021 at 3:26 AM Peter Xu wrote: > > On Sat, Oct 09, 2021 at 04:56:13AM -0300, Leonardo Bras wrote: > > @@ -105,7 +105,13 @@ static int nocomp_send_prepare(MultiFDSendParams *p, > > uint32_t used, > > */ > > static int nocomp_send_write(MultiFDSendParams *p, uint32_t used, Error

Re: [PATCH v4 3/3] multifd: Implement zerocopy write in multifd migration (multifd-zerocopy)

2021-10-26 Thread Leonardo Bras Soares Passos
On Wed, Oct 13, 2021 at 3:24 AM Peter Xu wrote: > > On Sat, Oct 09, 2021 at 04:56:13AM -0300, Leonardo Bras wrote: > > diff --git a/qapi/migration.json b/qapi/migration.json > > index 88f07baedd..c4890cbb54 100644 > > --- a/qapi/migration.json > > +++ b/qapi/migration.json > > @@ -724,6 +724,11 @@

Re: [PATCH v4 3/3] multifd: Implement zerocopy write in multifd migration (multifd-zerocopy)

2021-10-12 Thread Peter Xu
On Sat, Oct 09, 2021 at 04:56:13AM -0300, Leonardo Bras wrote: > @@ -105,7 +105,13 @@ static int nocomp_send_prepare(MultiFDSendParams *p, > uint32_t used, > */ > static int nocomp_send_write(MultiFDSendParams *p, uint32_t used, Error > **errp) > { > -return qio_channel_writev_all(p->c, p

Re: [PATCH v4 3/3] multifd: Implement zerocopy write in multifd migration (multifd-zerocopy)

2021-10-12 Thread Peter Xu
On Sat, Oct 09, 2021 at 04:56:13AM -0300, Leonardo Bras wrote: > diff --git a/qapi/migration.json b/qapi/migration.json > index 88f07baedd..c4890cbb54 100644 > --- a/qapi/migration.json > +++ b/qapi/migration.json > @@ -724,6 +724,11 @@ > # will consume more CPU. > #

Re: [PATCH v4 3/3] multifd: Implement zerocopy write in multifd migration (multifd-zerocopy)

2021-10-11 Thread Markus Armbruster
Leonardo Bras Soares Passos writes: > Hello Eric, > > On Mon, Oct 11, 2021 at 4:32 PM Eric Blake wrote: >> >> On Sat, Oct 09, 2021 at 04:56:13AM -0300, Leonardo Bras wrote: >> > Implement zerocopy on nocomp_send_write(), by making use of QIOChannel >> > zerocopy interface. >> > >> > Change multi

Re: [PATCH v4 3/3] multifd: Implement zerocopy write in multifd migration (multifd-zerocopy)

2021-10-11 Thread Leonardo Bras Soares Passos
Hello Eric, On Mon, Oct 11, 2021 at 4:32 PM Eric Blake wrote: > > On Sat, Oct 09, 2021 at 04:56:13AM -0300, Leonardo Bras wrote: > > Implement zerocopy on nocomp_send_write(), by making use of QIOChannel > > zerocopy interface. > > > > Change multifd_send_sync_main() so it can distinguish the las

Re: [PATCH v4 3/3] multifd: Implement zerocopy write in multifd migration (multifd-zerocopy)

2021-10-11 Thread Eric Blake
On Sat, Oct 09, 2021 at 04:56:13AM -0300, Leonardo Bras wrote: > Implement zerocopy on nocomp_send_write(), by making use of QIOChannel > zerocopy interface. > > Change multifd_send_sync_main() so it can distinguish the last sync from > the setup and per-iteration ones, so a flush_zerocopy() can b

[PATCH v4 3/3] multifd: Implement zerocopy write in multifd migration (multifd-zerocopy)

2021-10-09 Thread Leonardo Bras
Implement zerocopy on nocomp_send_write(), by making use of QIOChannel zerocopy interface. Change multifd_send_sync_main() so it can distinguish the last sync from the setup and per-iteration ones, so a flush_zerocopy() can be called at the last sync in order to make sure all RAM is sent before fi