Re: [PATCH v4 6/6] hw/cxl: Add clear poison mailbox command support.

2023-03-14 Thread Fan Ni
The 03/03/2023 15:09, Jonathan Cameron wrote: > Current implementation is very simple so many of the corner > cases do not exist (e.g. fragmenting larger poison list entries) > > Signed-off-by: Jonathan Cameron > --- Reviewed-by: Fan Ni One minor thing as mentioned below. > v4: > - Fix off by

Re: [PATCH v4 6/6] hw/cxl: Add clear poison mailbox command support.

2023-03-13 Thread Jonathan Cameron via
On Fri, 3 Mar 2023 15:09:08 + Jonathan Cameron wrote: > Current implementation is very simple so many of the corner > cases do not exist (e.g. fragmenting larger poison list entries) > > Signed-off-by: Jonathan Cameron Another case in here of directly accessing MemoryRegion->size. I'll fix

Re: [PATCH v4 6/6] hw/cxl: Add clear poison mailbox command support.

2023-03-06 Thread Jonathan Cameron via
On Fri, 3 Mar 2023 22:47:20 -0800 Ira Weiny wrote: > Jonathan Cameron wrote: > > Current implementation is very simple so many of the corner > > cases do not exist (e.g. fragmenting larger poison list entries) > > One coding style change at the bottom and I'm still hung up on that loop >

Re: [PATCH v4 6/6] hw/cxl: Add clear poison mailbox command support.

2023-03-03 Thread Ira Weiny
Jonathan Cameron wrote: > Current implementation is very simple so many of the corner > cases do not exist (e.g. fragmenting larger poison list entries) One coding style change at the bottom and I'm still hung up on that loop logic... > > Signed-off-by: Jonathan Cameron > --- > v4: > - Fix off

[PATCH v4 6/6] hw/cxl: Add clear poison mailbox command support.

2023-03-03 Thread Jonathan Cameron via
Current implementation is very simple so many of the corner cases do not exist (e.g. fragmenting larger poison list entries) Signed-off-by: Jonathan Cameron --- v4: - Fix off by one on check of edge of vmr (cut and paste from similar but long fixed in the volatile memory series) - Drop