Re: [PATCH v5 02/54] accel/tcg: Honor atomicity of loads

2023-05-16 Thread Richard Henderson
On 5/16/23 06:13, Peter Maydell wrote: On Mon, 15 May 2023 at 15:35, Richard Henderson wrote: Create ldst_atomicity.c.inc. Not required for user-only code loads, because we've ensured that the page is read-only before beginning to translate code. Signed-off-by: Richard Henderson --- v5:

Re: [PATCH v5 02/54] accel/tcg: Honor atomicity of loads

2023-05-16 Thread Peter Maydell
On Mon, 15 May 2023 at 15:35, Richard Henderson wrote: > > Create ldst_atomicity.c.inc. > > Not required for user-only code loads, because we've ensured that > the page is read-only before beginning to translate code. > > Signed-off-by: Richard Henderson > --- > v5: Dropped r-b because of

Re: [PATCH v5 02/54] accel/tcg: Honor atomicity of loads

2023-05-15 Thread Richard Henderson
On 5/15/23 09:43, Peter Maydell wrote: +static uint16_t load_atom_2(CPUArchState *env, uintptr_t ra, +void *pv, MemOp memop) +{ +uintptr_t pi = (uintptr_t)pv; +int atmax; + +if (likely((pi & 1) == 0)) { +return load_atomic2(pv); +} +if

Re: [PATCH v5 02/54] accel/tcg: Honor atomicity of loads

2023-05-15 Thread Peter Maydell
On Mon, 15 May 2023 at 15:35, Richard Henderson wrote: > > Create ldst_atomicity.c.inc. > > Not required for user-only code loads, because we've ensured that > the page is read-only before beginning to translate code. > > Signed-off-by: Richard Henderson > --- > v5: Dropped r-b because of

[PATCH v5 02/54] accel/tcg: Honor atomicity of loads

2023-05-15 Thread Richard Henderson
Create ldst_atomicity.c.inc. Not required for user-only code loads, because we've ensured that the page is read-only before beginning to translate code. Signed-off-by: Richard Henderson --- v5: Dropped r-b because of MO_ATOM_* reorg --- accel/tcg/cputlb.c | 175 +++---