Re: [PATCH v5 06/36] qapi: Remove wildcard includes

2020-10-06 Thread Philippe Mathieu-Daudé
On 10/5/20 9:51 PM, John Snow wrote: > Wildcard includes become hard to manage when refactoring and dealing > with circular dependencies with strictly typed mypy. > > flake8 also flags each one as a warning, as it is not smart enough to > know which names exist in the imported file. > > Remove th

[PATCH v5 06/36] qapi: Remove wildcard includes

2020-10-05 Thread John Snow
Wildcard includes become hard to manage when refactoring and dealing with circular dependencies with strictly typed mypy. flake8 also flags each one as a warning, as it is not smart enough to know which names exist in the imported file. Remove them and include things explicitly by name instead.