Re: [PATCH v5 1/1] qga/linux: Add new api 'guest-network-get-route'

2024-06-12 Thread Konstantin Kostiuk
Hi Daniel and Philippe Is it ok to add the version filed to the GuestNetworkRoute struct to indicate that this is an IPv4 or an IPv6 route or is it better to have two different structures? Best Regards, Konstantin Kostiuk. On Wed, Jun 12, 2024 at 3:53 PM Daniel P. Berrangé wrote: > On Wed, Ju

Re: [PATCH v5 1/1] qga/linux: Add new api 'guest-network-get-route'

2024-06-12 Thread Daniel P . Berrangé
On Wed, Jun 12, 2024 at 02:48:24PM +0200, Philippe Mathieu-Daudé wrote: > Hi Dehan, > > On 12/6/24 12:31, Dehan Meng wrote: > > The Route information of the Linux VM needs to be used > > by administrators and users when debugging network problems > > and troubleshooting. > > > > Signed-off-by: De

Re: [PATCH v5 1/1] qga/linux: Add new api 'guest-network-get-route'

2024-06-12 Thread Philippe Mathieu-Daudé
Hi Dehan, On 12/6/24 12:31, Dehan Meng wrote: The Route information of the Linux VM needs to be used by administrators and users when debugging network problems and troubleshooting. Signed-off-by: Dehan Meng --- qga/commands-posix.c | 81 qga/com

[PATCH v5 1/1] qga/linux: Add new api 'guest-network-get-route'

2024-06-12 Thread Dehan Meng
The Route information of the Linux VM needs to be used by administrators and users when debugging network problems and troubleshooting. Signed-off-by: Dehan Meng --- qga/commands-posix.c | 81 qga/commands-win32.c | 6 qga/qapi-schema.json | 56