Re: [PATCH v5 3/3] ppc: Enable 2nd DAWR support on p10

2023-07-07 Thread Shivaprasad G Bhat
Hi David, All, I am revisiting/reviving this patch. On 5/5/21 11:20, David Gibson wrote: On Wed, Apr 21, 2021 at 11:50:40AM +0530, Ravi Bangoria wrote: Hi David, On 4/19/21 10:23 AM, David Gibson wrote: On Mon, Apr 12, 2021 at 05:14:33PM +0530, Ravi Bangoria wrote: Since we have

Re: [PATCH v5 3/3] ppc: Enable 2nd DAWR support on p10

2021-05-04 Thread David Gibson
On Wed, Apr 21, 2021 at 11:50:40AM +0530, Ravi Bangoria wrote: > Hi David, > > On 4/19/21 10:23 AM, David Gibson wrote: > > On Mon, Apr 12, 2021 at 05:14:33PM +0530, Ravi Bangoria wrote: > > > As per the PAPR, bit 0 of byte 64 in pa-features property indicates > > > availability of 2nd DAWR

Re: [PATCH v5 3/3] ppc: Enable 2nd DAWR support on p10

2021-04-21 Thread Richard Henderson
On 4/21/21 6:56 PM, David Gibson wrote: I don't actually know if qemu has TCG watchpoint support on any hardware. Presumably it would mean instrumenting all the tcg loads and stores. We tag the soft tlb for pages that contain watchpoints. See include/hw/core/cpu.h: cpu_watchpoint_insert

Re: [PATCH v5 3/3] ppc: Enable 2nd DAWR support on p10

2021-04-21 Thread David Gibson
On Wed, Apr 21, 2021 at 12:24:22PM +0530, Ravi Bangoria wrote: > Hi Cedric, > > On 4/21/21 12:01 PM, Cédric Le Goater wrote: > > On 4/21/21 8:20 AM, Ravi Bangoria wrote: > > > Hi David, > > > > > > On 4/19/21 10:23 AM, David Gibson wrote: > > > > On Mon, Apr 12, 2021 at 05:14:33PM +0530, Ravi

Re: [PATCH v5 3/3] ppc: Enable 2nd DAWR support on p10

2021-04-21 Thread Ravi Bangoria
Hi Cedric, On 4/21/21 12:01 PM, Cédric Le Goater wrote: On 4/21/21 8:20 AM, Ravi Bangoria wrote: Hi David, On 4/19/21 10:23 AM, David Gibson wrote: On Mon, Apr 12, 2021 at 05:14:33PM +0530, Ravi Bangoria wrote: As per the PAPR, bit 0 of byte 64 in pa-features property indicates availability

Re: [PATCH v5 3/3] ppc: Enable 2nd DAWR support on p10

2021-04-21 Thread Cédric Le Goater
On 4/21/21 8:20 AM, Ravi Bangoria wrote: > Hi David, > > On 4/19/21 10:23 AM, David Gibson wrote: >> On Mon, Apr 12, 2021 at 05:14:33PM +0530, Ravi Bangoria wrote: >>> As per the PAPR, bit 0 of byte 64 in pa-features property indicates >>> availability of 2nd DAWR registers. i.e. If this bit is

Re: [PATCH v5 3/3] ppc: Enable 2nd DAWR support on p10

2021-04-21 Thread Ravi Bangoria
Hi David, On 4/19/21 10:23 AM, David Gibson wrote: On Mon, Apr 12, 2021 at 05:14:33PM +0530, Ravi Bangoria wrote: As per the PAPR, bit 0 of byte 64 in pa-features property indicates availability of 2nd DAWR registers. i.e. If this bit is set, 2nd DAWR is present, otherwise not. Use

Re: [PATCH v5 3/3] ppc: Enable 2nd DAWR support on p10

2021-04-18 Thread David Gibson
On Mon, Apr 12, 2021 at 05:14:33PM +0530, Ravi Bangoria wrote: > As per the PAPR, bit 0 of byte 64 in pa-features property indicates > availability of 2nd DAWR registers. i.e. If this bit is set, 2nd > DAWR is present, otherwise not. Use KVM_CAP_PPC_DAWR1 capability to > find whether kvm supports

Re: [PATCH v5 3/3] ppc: Enable 2nd DAWR support on p10

2021-04-12 Thread Cédric Le Goater
On 4/12/21 1:44 PM, Ravi Bangoria wrote: > As per the PAPR, bit 0 of byte 64 in pa-features property indicates > availability of 2nd DAWR registers. i.e. If this bit is set, 2nd > DAWR is present, otherwise not. Use KVM_CAP_PPC_DAWR1 capability to > find whether kvm supports 2nd DAWR or not. If

[PATCH v5 3/3] ppc: Enable 2nd DAWR support on p10

2021-04-12 Thread Ravi Bangoria
As per the PAPR, bit 0 of byte 64 in pa-features property indicates availability of 2nd DAWR registers. i.e. If this bit is set, 2nd DAWR is present, otherwise not. Use KVM_CAP_PPC_DAWR1 capability to find whether kvm supports 2nd DAWR or not. If it's supported, allow user to set the pa-feature