Re: [PATCH v5 6/7] acpi/ghes: add support for generic error injection via QAPI

2024-08-13 Thread Mauro Carvalho Chehab
Em Mon, 12 Aug 2024 11:39:00 +0200 Igor Mammedov escreveu: > > We may also store cper_offset there via bios_linker_loader_add_pointer() > > and/or use bios_linker_loader_write_pointer(), but I can't see how the > > data stored there can be retrieved, nor any advantage of using it instead > > of t

Re: [PATCH v5 6/7] acpi/ghes: add support for generic error injection via QAPI

2024-08-12 Thread Igor Mammedov
On Thu, 8 Aug 2024 20:19:03 +0200 Mauro Carvalho Chehab wrote: > Em Thu, 8 Aug 2024 10:11:07 +0200 > Igor Mammedov escreveu: > > > On Wed, 7 Aug 2024 15:25:47 +0100 > > Jonathan Cameron wrote: > > > > > On Tue, 6 Aug 2024 16:31:13 +0200 > > > Igor Mammedov wrote: > > > > > > > On Fri,

Re: [PATCH v5 6/7] acpi/ghes: add support for generic error injection via QAPI

2024-08-08 Thread Mauro Carvalho Chehab
Em Thu, 8 Aug 2024 10:11:07 +0200 Igor Mammedov escreveu: > On Wed, 7 Aug 2024 15:25:47 +0100 > Jonathan Cameron wrote: > > > On Tue, 6 Aug 2024 16:31:13 +0200 > > Igor Mammedov wrote: > > > > > On Fri, 2 Aug 2024 23:44:01 +0200 > > > Mauro Carvalho Chehab wrote: > > > > > > > Provid

Re: [PATCH v5 6/7] acpi/ghes: add support for generic error injection via QAPI

2024-08-08 Thread Igor Mammedov
On Thu, 8 Aug 2024 14:11:14 +0200 Mauro Carvalho Chehab wrote: > Em Tue, 6 Aug 2024 16:31:13 +0200 > Igor Mammedov escreveu: > > > > +/* Could also be read back from the error_block_address register */ > > > +*error_block_addr = base + > > > +ACPI_GHES_ERROR_SOURCE_COUNT * sizeo

Re: [PATCH v5 6/7] acpi/ghes: add support for generic error injection via QAPI

2024-08-08 Thread Mauro Carvalho Chehab
Em Tue, 6 Aug 2024 16:31:13 +0200 Igor Mammedov escreveu: > > +/* Could also be read back from the error_block_address register */ > > +*error_block_addr = base + > > +ACPI_GHES_ERROR_SOURCE_COUNT * sizeof(uint64_t) + > > +ACPI_GHES_ERROR_SOURCE_COUNT * sizeof(uint64_t) +

Re: [PATCH v5 6/7] acpi/ghes: add support for generic error injection via QAPI

2024-08-08 Thread Igor Mammedov
On Wed, 7 Aug 2024 15:25:47 +0100 Jonathan Cameron wrote: > On Tue, 6 Aug 2024 16:31:13 +0200 > Igor Mammedov wrote: > > > On Fri, 2 Aug 2024 23:44:01 +0200 > > Mauro Carvalho Chehab wrote: > > > > > Provide a generic interface for error injection via GHESv2. > > > > > > This patch is co-

Re: [PATCH v5 6/7] acpi/ghes: add support for generic error injection via QAPI

2024-08-07 Thread Jonathan Cameron via
On Tue, 6 Aug 2024 16:31:13 +0200 Igor Mammedov wrote: > On Fri, 2 Aug 2024 23:44:01 +0200 > Mauro Carvalho Chehab wrote: > > > Provide a generic interface for error injection via GHESv2. > > > > This patch is co-authored: > > - original ghes logic to inject a simple ARM record by Shiju J

Re: [PATCH v5 6/7] acpi/ghes: add support for generic error injection via QAPI

2024-08-07 Thread Igor Mammedov
On Wed, 7 Aug 2024 15:23:57 +0200 Mauro Carvalho Chehab wrote: > Em Wed, 7 Aug 2024 10:34:36 +0100 > Jonathan Cameron escreveu: > > > On Wed, 7 Aug 2024 09:47:50 +0200 > > Mauro Carvalho Chehab wrote: > > > > > Em Tue, 6 Aug 2024 16:31:13 +0200 > > > Igor Mammedov escreveu: > > > > >

Re: [PATCH v5 6/7] acpi/ghes: add support for generic error injection via QAPI

2024-08-07 Thread Igor Mammedov
On Wed, 7 Aug 2024 10:34:36 +0100 Jonathan Cameron wrote: > On Wed, 7 Aug 2024 09:47:50 +0200 > Mauro Carvalho Chehab wrote: > > > Em Tue, 6 Aug 2024 16:31:13 +0200 > > Igor Mammedov escreveu: > > > > > PS: > > > looking at the code, ACPI_GHES_MAX_RAW_DATA_LENGTH is 1K > > > and it is the t

Re: [PATCH v5 6/7] acpi/ghes: add support for generic error injection via QAPI

2024-08-07 Thread Mauro Carvalho Chehab
Em Wed, 7 Aug 2024 10:34:36 +0100 Jonathan Cameron escreveu: > On Wed, 7 Aug 2024 09:47:50 +0200 > Mauro Carvalho Chehab wrote: > > > Em Tue, 6 Aug 2024 16:31:13 +0200 > > Igor Mammedov escreveu: > > > > > PS: > > > looking at the code, ACPI_GHES_MAX_RAW_DATA_LENGTH is 1K > > > and it is th

Re: [PATCH v5 6/7] acpi/ghes: add support for generic error injection via QAPI

2024-08-07 Thread Jonathan Cameron via
On Wed, 7 Aug 2024 09:47:50 +0200 Mauro Carvalho Chehab wrote: > Em Tue, 6 Aug 2024 16:31:13 +0200 > Igor Mammedov escreveu: > > > PS: > > looking at the code, ACPI_GHES_MAX_RAW_DATA_LENGTH is 1K > > and it is the total size of a error block for a error source. > > > > However acpi_hest_ghes.r

Re: [PATCH v5 6/7] acpi/ghes: add support for generic error injection via QAPI

2024-08-07 Thread Mauro Carvalho Chehab
Em Tue, 6 Aug 2024 16:31:13 +0200 Igor Mammedov escreveu: > PS: > looking at the code, ACPI_GHES_MAX_RAW_DATA_LENGTH is 1K > and it is the total size of a error block for a error source. > > However acpi_hest_ghes.rst (3) says it should be 4K, > am I mistaken? Maybe Jonathan knows better, but I

Re: [PATCH v5 6/7] acpi/ghes: add support for generic error injection via QAPI

2024-08-06 Thread Igor Mammedov
On Fri, 2 Aug 2024 23:44:01 +0200 Mauro Carvalho Chehab wrote: > Provide a generic interface for error injection via GHESv2. > > This patch is co-authored: > - original ghes logic to inject a simple ARM record by Shiju Jose; > - generic logic to handle block addresses by Jonathan Camero

RE: [PATCH v5 6/7] acpi/ghes: add support for generic error injection via QAPI

2024-08-06 Thread Shiju Jose via
.org; qemu-devel@nongnu.org >Subject: [PATCH v5 6/7] acpi/ghes: add support for generic error injection via >QAPI > >Provide a generic interface for error injection via GHESv2. > >This patch is co-authored: >- original ghes logic to inject a simple ARM record by Shiju Jose; &

Re: [PATCH v5 6/7] acpi/ghes: add support for generic error injection via QAPI

2024-08-05 Thread Jonathan Cameron via
On Fri, 2 Aug 2024 23:44:01 +0200 Mauro Carvalho Chehab wrote: > Provide a generic interface for error injection via GHESv2. > > This patch is co-authored: > - original ghes logic to inject a simple ARM record by Shiju Jose; > - generic logic to handle block addresses by Jonathan Camero

[PATCH v5 6/7] acpi/ghes: add support for generic error injection via QAPI

2024-08-02 Thread Mauro Carvalho Chehab
Provide a generic interface for error injection via GHESv2. This patch is co-authored: - original ghes logic to inject a simple ARM record by Shiju Jose; - generic logic to handle block addresses by Jonathan Cameron; - generic GHESv2 error inject by Mauro Carvalho Chehab; Co-authored-