Re: [PATCH v6 06/11] target/arm: Factor out code for setting MTE TCF0 field

2024-06-29 Thread Peter Maydell
On Fri, 28 Jun 2024 at 19:13, Gustavo Romero wrote: > Re-reading it after your clarifications makes it clear, but the first time > Phil pointed it out the phrases: > > "[...] since the .c file will have already included it." and > "Headers should normally include everything they need beyond

Re: [PATCH v6 06/11] target/arm: Factor out code for setting MTE TCF0 field

2024-06-28 Thread Gustavo Romero
Hi Richard, On 6/28/24 2:00 PM, Richard Henderson wrote: On 6/28/24 08:49, Gustavo Romero wrote: I thought you meant osdep.h should not be included _at all_ in my case, either in mte_user_helper.h or in mte_user_helper.c. Maybe the wording in the docs should be "Do not include "qemu/osdep.h"

Re: [PATCH v6 06/11] target/arm: Factor out code for setting MTE TCF0 field

2024-06-28 Thread Richard Henderson
On 6/28/24 08:49, Gustavo Romero wrote: I thought you meant osdep.h should not be included _at all_ in my case, either in mte_user_helper.h or in mte_user_helper.c. Maybe the wording in the docs should be "Do not include "qemu/osdep.h" from header files. Include it from .c files, when

Re: [PATCH v6 06/11] target/arm: Factor out code for setting MTE TCF0 field

2024-06-28 Thread Philippe Mathieu-Daudé
On 28/6/24 17:49, Gustavo Romero wrote: Hi Phil, On 6/28/24 4:08 AM, Philippe Mathieu-Daudé wrote: On 28/6/24 07:08, Gustavo Romero wrote: Factor out the code used for setting the MTE TCF0 field from the prctl code into a convenient function. Other subsystems, like gdbstub, need to set this

Re: [PATCH v6 06/11] target/arm: Factor out code for setting MTE TCF0 field

2024-06-28 Thread Gustavo Romero
Hi Phil, On 6/28/24 4:08 AM, Philippe Mathieu-Daudé wrote: On 28/6/24 07:08, Gustavo Romero wrote: Factor out the code used for setting the MTE TCF0 field from the prctl code into a convenient function. Other subsystems, like gdbstub, need to set this field as well, so keep it as a separate

Re: [PATCH v6 06/11] target/arm: Factor out code for setting MTE TCF0 field

2024-06-28 Thread Alex Bennée
Gustavo Romero writes: > Hi Alex, > > On 6/28/24 9:14 AM, Alex Bennée wrote: >> Gustavo Romero writes: >> >>> Factor out the code used for setting the MTE TCF0 field from the prctl >>> code into a convenient function. Other subsystems, like gdbstub, need to >>> set this field as well, so keep

Re: [PATCH v6 06/11] target/arm: Factor out code for setting MTE TCF0 field

2024-06-28 Thread Gustavo Romero
Hi Alex, On 6/28/24 9:14 AM, Alex Bennée wrote: Gustavo Romero writes: Factor out the code used for setting the MTE TCF0 field from the prctl code into a convenient function. Other subsystems, like gdbstub, need to set this field as well, so keep it as a separate function to avoid

Re: [PATCH v6 06/11] target/arm: Factor out code for setting MTE TCF0 field

2024-06-28 Thread Alex Bennée
Gustavo Romero writes: > Factor out the code used for setting the MTE TCF0 field from the prctl > code into a convenient function. Other subsystems, like gdbstub, need to > set this field as well, so keep it as a separate function to avoid > duplication and ensure consistency in how this field

Re: [PATCH v6 06/11] target/arm: Factor out code for setting MTE TCF0 field

2024-06-28 Thread Philippe Mathieu-Daudé
On 28/6/24 07:08, Gustavo Romero wrote: Factor out the code used for setting the MTE TCF0 field from the prctl code into a convenient function. Other subsystems, like gdbstub, need to set this field as well, so keep it as a separate function to avoid duplication and ensure consistency in how

[PATCH v6 06/11] target/arm: Factor out code for setting MTE TCF0 field

2024-06-27 Thread Gustavo Romero
Factor out the code used for setting the MTE TCF0 field from the prctl code into a convenient function. Other subsystems, like gdbstub, need to set this field as well, so keep it as a separate function to avoid duplication and ensure consistency in how this field is set across the board.