Re: [PATCH v7 02/12] target/riscv/cpu.c: remove set_vext_version()

2023-04-20 Thread Daniel Henrique Barboza
On 4/19/23 20:37, Alistair Francis wrote: On Tue, Apr 18, 2023 at 12:08 AM Daniel Henrique Barboza wrote: This setter is doing nothing else but setting env->vext_ver. Assign the value directly. Signed-off-by: Daniel Henrique Barboza Reviewed-by: LIU Zhiwei Reviewed-by: Weiwei Li I thi

Re: [PATCH v7 02/12] target/riscv/cpu.c: remove set_vext_version()

2023-04-19 Thread Alistair Francis
On Tue, Apr 18, 2023 at 12:08 AM Daniel Henrique Barboza wrote: > > This setter is doing nothing else but setting env->vext_ver. Assign the > value directly. > > Signed-off-by: Daniel Henrique Barboza > Reviewed-by: LIU Zhiwei > Reviewed-by: Weiwei Li I think you dropped my previous reviews A

[PATCH v7 02/12] target/riscv/cpu.c: remove set_vext_version()

2023-04-17 Thread Daniel Henrique Barboza
This setter is doing nothing else but setting env->vext_ver. Assign the value directly. Signed-off-by: Daniel Henrique Barboza Reviewed-by: LIU Zhiwei Reviewed-by: Weiwei Li --- target/riscv/cpu.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/target/riscv/cpu.c b/ta