Re: [PATCH v9 12/14] target/riscv: rvk: add CSR support for Zkr

2022-04-13 Thread Weiwei Li
Thanks for your comments. 在 2022/4/14 上午7:57, Alistair Francis 写道: On Mon, Apr 11, 2022 at 2:46 PM Weiwei Li wrote: Hi, any comments on this patch or patchset? Currently, read-only instruction to access Seed CSR is checked as a special case in helper_csrr as suggested in

Re: [PATCH v9 12/14] target/riscv: rvk: add CSR support for Zkr

2022-04-13 Thread Alistair Francis
On Mon, Apr 11, 2022 at 2:46 PM Weiwei Li wrote: > > Hi, any comments on this patch or patchset? > > Currently, read-only instruction to access Seed CSR is checked as a > special case in helper_csrr as suggested in > > https://lists.nongnu.org/archive/html/qemu-riscv/2022-03/msg00146.html. Ah

Re: [PATCH v9 12/14] target/riscv: rvk: add CSR support for Zkr

2022-04-10 Thread Weiwei Li
Hi, any comments on this patch or patchset? Currently, read-only instruction to access Seed CSR is checked as a special case in helper_csrr as suggested in https://lists.nongnu.org/archive/html/qemu-riscv/2022-03/msg00146.html. (The new version for that patch is in

[PATCH v9 12/14] target/riscv: rvk: add CSR support for Zkr

2022-03-17 Thread Weiwei Li
- add SEED CSR which must be accessed with a read-write instruction: A read-only instruction such as CSRRS/CSRRC with rs1=x0 or CSRRSI/CSRRCI with uimm=0 will raise an illegal instruction exception. - add USEED, SSEED fields for MSECCFG CSR Co-authored-by: Ruibo Lu Co-authored-by: Zewen Ye