Re: [PULL 00/51] Build system, i386 changes for 2023-09-07

2023-09-11 Thread Philippe Mathieu-Daudé
On 11/9/23 12:11, Philippe Mathieu-Daudé wrote: On 8/9/23 21:21, Paolo Bonzini wrote: On Fri, Sep 8, 2023 at 7:28 PM Kevin Wolf wrote: Maybe the calls aren't eliminated because --enable-debug implies -O0? My experience is that it will still fold simple dead code like "0 && foo()" or even

Re: [PULL 00/51] Build system, i386 changes for 2023-09-07

2023-09-11 Thread Thomas Huth
On Mon, 2023-09-11 at 07:06 -0400, Stefan Hajnoczi wrote: > On Mon, 11 Sept 2023 at 06:10, Philippe Mathieu-Daudé > wrote: > > > > On 8/9/23 17:47, Stefan Hajnoczi wrote: > > > I wonder how it passed CI? > > > https://gitlab.com/qemu-project/qemu/-/pipelines/996175923/ > > > > The conditions

Re: [PULL 00/51] Build system, i386 changes for 2023-09-07

2023-09-11 Thread Kevin Wolf
Am 11.09.2023 um 12:22 hat Philippe Mathieu-Daudé geschrieben: > On 11/9/23 12:10, Philippe Mathieu-Daudé wrote: > > On 8/9/23 17:47, Stefan Hajnoczi wrote: > > > I wonder how it passed CI? > > > https://gitlab.com/qemu-project/qemu/-/pipelines/996175923/ > > > > The conditions are: > > - x86

Re: [PULL 00/51] Build system, i386 changes for 2023-09-07

2023-09-11 Thread Stefan Hajnoczi
On Mon, 11 Sept 2023 at 06:10, Philippe Mathieu-Daudé wrote: > > On 8/9/23 17:47, Stefan Hajnoczi wrote: > > I wonder how it passed CI? > > https://gitlab.com/qemu-project/qemu/-/pipelines/996175923/ > > The conditions are: > - x86 host > - both system / user emulation enabled > - KVM disabled >

Re: [PULL 00/51] Build system, i386 changes for 2023-09-07

2023-09-11 Thread Michael Tokarev
11.09.2023 13:41, Michael Tokarev: What can be done though is, instead of making kvm_arch_get_supported_cpuid et all a stubs, to replace them in .h file with an empty macro when some condition(s) are met.  In other words, fold kvm_enabled() "inside" of kvm_arch_get_supported_cpuid() and use

Re: [PULL 00/51] Build system, i386 changes for 2023-09-07

2023-09-11 Thread Michael Tokarev
08.09.2023 22:21, Paolo Bonzini wrote: On Fri, Sep 8, 2023 at 7:28 PM Kevin Wolf wrote: Maybe the calls aren't eliminated because --enable-debug implies -O0? My experience is that it will still fold simple dead code like "0 && foo()" or even "if (0) { ... }", but maybe it's a GCC vs. clang

Re: [PULL 00/51] Build system, i386 changes for 2023-09-07

2023-09-11 Thread Philippe Mathieu-Daudé
On 11/9/23 12:10, Philippe Mathieu-Daudé wrote: On 8/9/23 17:47, Stefan Hajnoczi wrote: I wonder how it passed CI? https://gitlab.com/qemu-project/qemu/-/pipelines/996175923/ The conditions are: - x86 host - both system / user emulation enabled - KVM disabled - debug enabled Oh, I forgot:

Re: [PULL 00/51] Build system, i386 changes for 2023-09-07

2023-09-11 Thread Philippe Mathieu-Daudé
On 8/9/23 21:21, Paolo Bonzini wrote: On Fri, Sep 8, 2023 at 7:28 PM Kevin Wolf wrote: Maybe the calls aren't eliminated because --enable-debug implies -O0? My experience is that it will still fold simple dead code like "0 && foo()" or even "if (0) { ... }", but maybe it's a GCC vs. clang

Re: [PULL 00/51] Build system, i386 changes for 2023-09-07

2023-09-11 Thread Philippe Mathieu-Daudé
On 8/9/23 17:47, Stefan Hajnoczi wrote: I wonder how it passed CI? https://gitlab.com/qemu-project/qemu/-/pipelines/996175923/ The conditions are: - x86 host - both system / user emulation enabled - KVM disabled - debug enabled We have jobs with 3 of the 4, but none with all the 4. Is it

Re: [PULL 00/51] Build system, i386 changes for 2023-09-07

2023-09-08 Thread Paolo Bonzini
On Fri, Sep 8, 2023 at 7:28 PM Kevin Wolf wrote: > Maybe the calls aren't eliminated because --enable-debug implies -O0? My experience is that it will still fold simple dead code like "0 && foo()" or even "if (0) { ... }", but maybe it's a GCC vs. clang difference. Philippe, I take it that you

Re: [PULL 00/51] Build system, i386 changes for 2023-09-07

2023-09-08 Thread Kevin Wolf
Am 08.09.2023 um 19:16 hat Kevin Wolf geschrieben: > Am 08.09.2023 um 18:11 hat Philippe Mathieu-Daudé geschrieben: > > Hi Kevin, > > > > On 8/9/23 17:01, Kevin Wolf wrote: > > > Am 07.09.2023 um 17:44 hat Stefan Hajnoczi geschrieben: > > > > Applied, thanks. > > > > > > > > Please update the

Re: [PULL 00/51] Build system, i386 changes for 2023-09-07

2023-09-08 Thread Michael Tokarev
08.09.2023 20:16, Kevin Wolf: Am 08.09.2023 um 18:11 hat Philippe Mathieu-Daudé geschrieben: Hi Kevin, On 8/9/23 17:01, Kevin Wolf wrote: Am 07.09.2023 um 17:44 hat Stefan Hajnoczi geschrieben: Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/8.2 for any

Re: [PULL 00/51] Build system, i386 changes for 2023-09-07

2023-09-08 Thread Daniel P . Berrangé
On Fri, Sep 08, 2023 at 07:16:16PM +0200, Kevin Wolf wrote: > Am 08.09.2023 um 18:11 hat Philippe Mathieu-Daudé geschrieben: > > Hi Kevin, > > > > On 8/9/23 17:01, Kevin Wolf wrote: > > > Am 07.09.2023 um 17:44 hat Stefan Hajnoczi geschrieben: > > > > Applied, thanks. > > > > > > > > Please

Re: [PULL 00/51] Build system, i386 changes for 2023-09-07

2023-09-08 Thread Kevin Wolf
Am 08.09.2023 um 18:11 hat Philippe Mathieu-Daudé geschrieben: > Hi Kevin, > > On 8/9/23 17:01, Kevin Wolf wrote: > > Am 07.09.2023 um 17:44 hat Stefan Hajnoczi geschrieben: > > > Applied, thanks. > > > > > > Please update the changelog at https://wiki.qemu.org/ChangeLog/8.2 for > > > any

Re: [PULL 00/51] Build system, i386 changes for 2023-09-07

2023-09-08 Thread Philippe Mathieu-Daudé
Hi Kevin, On 8/9/23 17:01, Kevin Wolf wrote: Am 07.09.2023 um 17:44 hat Stefan Hajnoczi geschrieben: Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/8.2 for any user-visible changes. Something in this has broken the build for me, it seems to be the

Re: [PULL 00/51] Build system, i386 changes for 2023-09-07

2023-09-08 Thread Stefan Hajnoczi
I wonder how it passed CI? https://gitlab.com/qemu-project/qemu/-/pipelines/996175923/ Stefan On Fri, 8 Sept 2023 at 11:02, Kevin Wolf wrote: > > Am 07.09.2023 um 17:44 hat Stefan Hajnoczi geschrieben: > > Applied, thanks. > > > > Please update the changelog at

Re: [PULL 00/51] Build system, i386 changes for 2023-09-07

2023-09-08 Thread Kevin Wolf
Am 07.09.2023 um 17:44 hat Stefan Hajnoczi geschrieben: > Applied, thanks. > > Please update the changelog at https://wiki.qemu.org/ChangeLog/8.2 for any > user-visible changes. Something in this has broken the build for me, it seems to be the linux-user binary that doesn't link any more:

Re: [PULL 00/51] Build system, i386 changes for 2023-09-07

2023-09-07 Thread Stefan Hajnoczi
Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/8.2 for any user-visible changes. signature.asc Description: PGP signature

[PULL 00/51] Build system, i386 changes for 2023-09-07

2023-09-07 Thread Paolo Bonzini
The following changes since commit 17780edd81d27fcfdb7a802efc870a99788bd2fc: Merge tag 'quick-fix-pull-request' of https://gitlab.com/bsdimp/qemu into staging (2023-08-31 10:06:29 -0400) are available in the Git repository at: https://gitlab.com/bonzini/qemu.git tags/for-upstream for you