Re: [PULL 09/20] target/tricore: Fix out-of-bounds index in imask instruction

2023-06-23 Thread Bastian Koppelmann
On Fri, Jun 23, 2023 at 01:29:23PM +0300, Michael Tokarev wrote: > 23.06.2023 12:51, Bastian Koppelmann wrote: > > Here we go: > https://www.qemu.org/docs/master/devel/stable-process.html > > Basically, any bugfix you, as a subsystem maintainer, think is good for > stable, > is good for stable

Re: [PULL 09/20] target/tricore: Fix out-of-bounds index in imask instruction

2023-06-23 Thread Michael Tokarev
23.06.2023 12:51, Bastian Koppelmann wrote: Is there anything else in this series worth picking up for stable, eg: Fix helper_ret() not correctly restoring PSW Fix RR_JLI clobbering reg A[11] These are rare cases where the guest does something wrong. It will not lead to a crash of QEMU.

Re: [PULL 09/20] target/tricore: Fix out-of-bounds index in imask instruction

2023-06-23 Thread Bastian Koppelmann
Hi Michael, On Fri, Jun 23, 2023 at 09:54:54AM +0300, Michael Tokarev wrote: > 22.06.2023 17:51, Bastian Koppelmann wrote: > .. > > > Is it a -stable material? > > > > Yes. If you pick this up, make sure you also pick up > > https://lore.kernel.org/qemu-devel/20230621161422.1652151-1-kbast...@ma

Re: [PULL 09/20] target/tricore: Fix out-of-bounds index in imask instruction

2023-06-22 Thread Michael Tokarev
22.06.2023 17:51, Bastian Koppelmann wrote: .. Is it a -stable material? Yes. If you pick this up, make sure you also pick up https://lore.kernel.org/qemu-devel/20230621161422.1652151-1-kbast...@mail.uni-paderborn.de/T/#md18391dd165c4fc2e60ddefb886f3522e715f487 which applies the same fix to ot

Re: [PULL 09/20] target/tricore: Fix out-of-bounds index in imask instruction

2023-06-22 Thread Bastian Koppelmann
On Thu, Jun 22, 2023 at 10:43:16AM +0300, Michael Tokarev wrote: > 21.06.2023 19:14, Bastian Koppelmann wrote: > > From: Siqi Chen > > > > When translating "imask" instruction of Tricore architecture, QEMU did not > > check whether the register index was out of bounds, resulting in a > > globa

Re: [PULL 09/20] target/tricore: Fix out-of-bounds index in imask instruction

2023-06-22 Thread Michael Tokarev
21.06.2023 19:14, Bastian Koppelmann wrote: From: Siqi Chen When translating "imask" instruction of Tricore architecture, QEMU did not check whether the register index was out of bounds, resulting in a global-buffer-overflow. Reviewed-by: Bastian Koppelmann Resolves: https://gitlab.com/qemu

[PULL 09/20] target/tricore: Fix out-of-bounds index in imask instruction

2023-06-21 Thread Bastian Koppelmann
From: Siqi Chen When translating "imask" instruction of Tricore architecture, QEMU did not check whether the register index was out of bounds, resulting in a global-buffer-overflow. Reviewed-by: Bastian Koppelmann Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1698 Reported-by: Siqi