Re: [PULL 1/1] machine: Disallow specifying topology parameters as zero

2021-08-17 Thread wangyanan (Y)
On 2021/8/17 20:22, Andrew Jones wrote: On Tue, Aug 17, 2021 at 01:06:19PM +0100, Peter Maydell wrote: On Tue, 17 Aug 2021 at 13:02, Andrew Jones wrote: On Mon, Aug 16, 2021 at 11:37:21PM +0200, Paolo Bonzini wrote: How do we know that no one has ever used such configuration? The conversion w

Re: [PULL 1/1] machine: Disallow specifying topology parameters as zero

2021-08-17 Thread Andrew Jones
On Tue, Aug 17, 2021 at 01:37:15PM +0100, Peter Maydell wrote: > On Tue, 17 Aug 2021 at 13:22, Andrew Jones wrote: > > > > On Tue, Aug 17, 2021 at 01:06:19PM +0100, Peter Maydell wrote: > > > On Tue, 17 Aug 2021 at 13:02, Andrew Jones wrote: > > > > > > > > On Mon, Aug 16, 2021 at 11:37:21PM +020

Re: [PULL 1/1] machine: Disallow specifying topology parameters as zero

2021-08-17 Thread Peter Maydell
On Tue, 17 Aug 2021 at 13:22, Andrew Jones wrote: > > On Tue, Aug 17, 2021 at 01:06:19PM +0100, Peter Maydell wrote: > > On Tue, 17 Aug 2021 at 13:02, Andrew Jones wrote: > > > > > > On Mon, Aug 16, 2021 at 11:37:21PM +0200, Paolo Bonzini wrote: > > > > How do we know that no one has ever used su

Re: [PULL 1/1] machine: Disallow specifying topology parameters as zero

2021-08-17 Thread Andrew Jones
On Tue, Aug 17, 2021 at 01:06:19PM +0100, Peter Maydell wrote: > On Tue, 17 Aug 2021 at 13:02, Andrew Jones wrote: > > > > On Mon, Aug 16, 2021 at 11:37:21PM +0200, Paolo Bonzini wrote: > > > How do we know that no one has ever used such configuration? The > > > conversion > > > was meant to be b

Re: [PULL 1/1] machine: Disallow specifying topology parameters as zero

2021-08-17 Thread Peter Maydell
On Tue, 17 Aug 2021 at 13:02, Andrew Jones wrote: > > On Mon, Aug 16, 2021 at 11:37:21PM +0200, Paolo Bonzini wrote: > > How do we know that no one has ever used such configuration? The conversion > > was meant to be bug-compatible. > > We don't. But we do know that a zero input value was never do

Re: [PULL 1/1] machine: Disallow specifying topology parameters as zero

2021-08-17 Thread Andrew Jones
On Mon, Aug 16, 2021 at 11:37:21PM +0200, Paolo Bonzini wrote: > How do we know that no one has ever used such configuration? The conversion > was meant to be bug-compatible. We don't. But we do know that a zero input value was never documented prior to 1e63fe68580, which has not yet been released

Re: [PULL 1/1] machine: Disallow specifying topology parameters as zero

2021-08-16 Thread Paolo Bonzini
How do we know that no one has ever used such configuration? The conversion was meant to be bug-compatible. Paolo Il lun 16 ago 2021, 23:06 Eduardo Habkost ha scritto: > From: Yanan Wang > > In the SMP configuration, we should either provide a topology > parameter with a reasonable value (grea

[PULL 1/1] machine: Disallow specifying topology parameters as zero

2021-08-16 Thread Eduardo Habkost
From: Yanan Wang In the SMP configuration, we should either provide a topology parameter with a reasonable value (greater than zero) or just omit it and QEMU will compute the missing value. Users should have never provided a configuration with parameters as zero (e.g. -smp 8,sockets=0) which shou