Re: [PULL 30/33] migration: do not restart VM after successful snapshot-load

2021-05-12 Thread Paolo Bonzini
On 12/05/21 09:45, Kevin Wolf wrote: I guess I'll wait for this new QMP bug to hit master, and then rebase my fix on top of it, with now two Fixes: lines. Or do you want to send a v2 of this pull request without this patch, Paolo? I managed to remove it from the tag before Peter pulled, so pro

Re: [PULL 30/33] migration: do not restart VM after successful snapshot-load

2021-05-12 Thread Paolo Bonzini
On 11/05/21 10:56, Dr. David Alan Gilbert wrote: * Paolo Bonzini (pbonz...@redhat.com) wrote: The HMP loadvm code is calling load_snapshot rather than qmp_snapshot_load, in order to bypass the job infrastructure. The code around it is almost the same, with one difference: hmp_loadvm is restarti

Re: [PULL 30/33] migration: do not restart VM after successful snapshot-load

2021-05-12 Thread Kevin Wolf
Am 11.05.2021 um 19:06 hat Daniel P. Berrangé geschrieben: > On Tue, May 11, 2021 at 04:13:47AM -0400, Paolo Bonzini wrote: > > The HMP loadvm code is calling load_snapshot rather than > > qmp_snapshot_load, in order to bypass the job infrastructure. The code > > around it is almost the same, with

Re: [PULL 30/33] migration: do not restart VM after successful snapshot-load

2021-05-11 Thread Daniel P . Berrangé
On Tue, May 11, 2021 at 04:13:47AM -0400, Paolo Bonzini wrote: > The HMP loadvm code is calling load_snapshot rather than > qmp_snapshot_load, in order to bypass the job infrastructure. The code > around it is almost the same, with one difference: hmp_loadvm is > restarting the VM if load_snapshot

Re: [PULL 30/33] migration: do not restart VM after successful snapshot-load

2021-05-11 Thread Dr. David Alan Gilbert
* Paolo Bonzini (pbonz...@redhat.com) wrote: > The HMP loadvm code is calling load_snapshot rather than > qmp_snapshot_load, in order to bypass the job infrastructure. The code > around it is almost the same, with one difference: hmp_loadvm is > restarting the VM if load_snapshot fails, qmp_snapsh

Re: [PULL 30/33] migration: do not restart VM after successful snapshot-load

2021-05-11 Thread Daniel P . Berrangé
On Tue, May 11, 2021 at 04:13:47AM -0400, Paolo Bonzini wrote: > The HMP loadvm code is calling load_snapshot rather than > qmp_snapshot_load, in order to bypass the job infrastructure. The code > around it is almost the same, with one difference: hmp_loadvm is > restarting the VM if load_snapshot

[PULL 30/33] migration: do not restart VM after successful snapshot-load

2021-05-11 Thread Paolo Bonzini
The HMP loadvm code is calling load_snapshot rather than qmp_snapshot_load, in order to bypass the job infrastructure. The code around it is almost the same, with one difference: hmp_loadvm is restarting the VM if load_snapshot fails, qmp_snapshot_load is doing so if load_snapshot succeeds. Fix t