Re: [PULL 5/5] qemu_set_log_filename: filename argument may be NULL

2020-02-12 Thread Richard Henderson
On 2/12/20 2:45 AM, Alex Bennée wrote: > > Richard Henderson writes: > >> On 1/30/20 1:38 PM, Stefan Hajnoczi wrote: >>> From: Salvador Fandino >>> >>> NULL is a valid log filename used to indicate we want to use stderr >>> but qemu_set_log_filename (which is called by bsd-user/main.c) was not

Re: [PULL 5/5] qemu_set_log_filename: filename argument may be NULL

2020-02-12 Thread Alex Bennée
Richard Henderson writes: > On 1/30/20 1:38 PM, Stefan Hajnoczi wrote: >> From: Salvador Fandino >> >> NULL is a valid log filename used to indicate we want to use stderr >> but qemu_set_log_filename (which is called by bsd-user/main.c) was not >> handling it correctly. >> >> That also made

Re: [PULL 5/5] qemu_set_log_filename: filename argument may be NULL

2020-02-11 Thread Richard Henderson
On 1/30/20 1:38 PM, Stefan Hajnoczi wrote: > From: Salvador Fandino > > NULL is a valid log filename used to indicate we want to use stderr > but qemu_set_log_filename (which is called by bsd-user/main.c) was not > handling it correctly. > > That also made redundant a couple of NULL checks in

[PULL 5/5] qemu_set_log_filename: filename argument may be NULL

2020-01-30 Thread Stefan Hajnoczi
From: Salvador Fandino NULL is a valid log filename used to indicate we want to use stderr but qemu_set_log_filename (which is called by bsd-user/main.c) was not handling it correctly. That also made redundant a couple of NULL checks in calling code which have been removed. Signed-off-by: