On 3/17/10, Anthony Liguori wrote:
> On 03/17/2010 03:56 PM, Paul Bolle wrote:
>
> > On Wed, 2010-03-17 at 15:41 -0500, Anthony Liguori wrote:
> >
> >
> > > On 03/17/2010 03:15 PM, Blue Swirl wrote:
> > >
> > >
> > > > This breaks build (gcc 4.3.2):
> > > >CCusb-linux.o
> > > > cc1: warnin
On 03/17/2010 03:56 PM, Paul Bolle wrote:
On Wed, 2010-03-17 at 15:41 -0500, Anthony Liguori wrote:
On 03/17/2010 03:15 PM, Blue Swirl wrote:
This breaks build (gcc 4.3.2):
CCusb-linux.o
cc1: warnings being treated as errors
/src/qemu/usb-linux.c: In function 'usb_linux_update
On Wed, 2010-03-17 at 15:41 -0500, Anthony Liguori wrote:
> On 03/17/2010 03:15 PM, Blue Swirl wrote:
> > This breaks build (gcc 4.3.2):
> >CCusb-linux.o
> > cc1: warnings being treated as errors
> > /src/qemu/usb-linux.c: In function 'usb_linux_update_endp_table':
> > /src/qemu/usb-lin
On 03/17/2010 03:15 PM, Blue Swirl wrote:
On 3/17/10, Paul Brook wrote:
If something should never happen (as in this case) then an abort/assert
> > is completely appropriate. Once things get that screwed up there's no
> > right answer, and the best thing we can do is term
On 3/17/10, Paul Brook wrote:
> > > If something should never happen (as in this case) then an abort/assert
> > > is completely appropriate. Once things get that screwed up there's no
> > > right answer, and the best thing we can do is terminate immediately to
> > > try and avoid further damage
> > If something should never happen (as in this case) then an abort/assert
> > is completely appropriate. Once things get that screwed up there's no
> > right answer, and the best thing we can do is terminate immediately to
> > try and avoid further damage.
>
> This case was:
>
> switch (foo & 0
On 03/17/2010 12:08 PM, Paul Brook wrote:
On 03/17/2010 11:14 AM, Paul Bolle wrote:
On Wed, 2010-03-17 at 10:59 -0500, Anthony Liguori wrote:
On 03/08/2010 06:58 AM, Paul Bolle wrote:
Signed-off-by: Paul Bolle
Applied. Thanks.
Paul Brook was "te
> On 03/17/2010 11:14 AM, Paul Bolle wrote:
> > On Wed, 2010-03-17 at 10:59 -0500, Anthony Liguori wrote:
> >> On 03/08/2010 06:58 AM, Paul Bolle wrote:
> >>> Signed-off-by: Paul Bolle
> >>
> >> Applied. Thanks.
> >
> > Paul Brook was "tempted to replace it by an abort()" (about one and a
> > half
On 03/17/2010 11:14 AM, Paul Bolle wrote:
On Wed, 2010-03-17 at 10:59 -0500, Anthony Liguori wrote:
On 03/08/2010 06:58 AM, Paul Bolle wrote:
Signed-off-by: Paul Bolle
Applied. Thanks.
Paul Brook was "tempted to replace it by an abort()" (about one and a
half week ag
On Wed, 2010-03-17 at 10:59 -0500, Anthony Liguori wrote:
> On 03/08/2010 06:58 AM, Paul Bolle wrote:
> > Signed-off-by: Paul Bolle
> >
> Applied. Thanks.
Paul Brook was "tempted to replace it by an abort()" (about one and a
half week ago). Did you perhaps miss that message or weren't you tem
On 03/08/2010 06:58 AM, Paul Bolle wrote:
Signed-off-by: Paul Bolle
Applied. Thanks.
Regards,
Anthony Liguori
---
usb-linux.c |3 ---
1 files changed, 0 insertions(+), 3 deletions(-)
diff --git a/usb-linux.c b/usb-linux.c
index a9c15c6..23155dd 100644
--- a/usb-linux.c
+++ b/usb-
> Signed-off-by: Paul Bolle
> ---
> usb-linux.c |3 ---
> 1 files changed, 0 insertions(+), 3 deletions(-)
>
> diff --git a/usb-linux.c b/usb-linux.c
> index a9c15c6..23155dd 100644
> --- a/usb-linux.c
> +++ b/usb-linux.c
> @@ -846,9 +846,6 @@ static int usb_linux_update_endp_table(USBHostDe
Signed-off-by: Paul Bolle
---
usb-linux.c |3 ---
1 files changed, 0 insertions(+), 3 deletions(-)
diff --git a/usb-linux.c b/usb-linux.c
index a9c15c6..23155dd 100644
--- a/usb-linux.c
+++ b/usb-linux.c
@@ -846,9 +846,6 @@ static int usb_linux_update_endp_table(USBHostDevice *s)
13 matches
Mail list logo
