Re: [Qemu-devel] [PATCH] Add ability to provide ifname when using netdev bridge or tap helper

2018-01-18 Thread Shaun Reitan
s Armbruster" Sent: 2018-01-18 03:53:29 AM Subject: Re: [Qemu-devel] [PATCH] Add ability to provide ifname when using netdev bridge or tap helper On 2018年01月18日 02:11, Shaun Reitan wrote: Ok, how should i proceed with this? I can attempt to write a whitelist/blacklist check if that is

Re: [Qemu-devel] [PATCH] Add ability to provide ifname when using netdev bridge or tap helper

2018-01-18 Thread Jason Wang
On 2018年01月18日 02:11, Shaun Reitan wrote: Ok, how should i proceed with this?  I can attempt to write a whitelist/blacklist check if that is what's needed. -- Shaun Reitan NDCHost.com I think you can try. Thanks

Re: [Qemu-devel] [PATCH] Add ability to provide ifname when using netdev bridge or tap helper

2018-01-17 Thread Shaun Reitan
Ok, how should i proceed with this? I can attempt to write a whitelist/blacklist check if that is what's needed. -- Shaun Reitan NDCHost.com -- Original Message -- From: "Eric Blake" To: "Shaun Reitan" ; qemu-devel@nongnu.org Cc: "Jason Wang" ; "Markus Armbruster" Sent: 1/17/2018 7

Re: [Qemu-devel] [PATCH] Add ability to provide ifname when using netdev bridge or tap helper

2018-01-17 Thread Eric Blake
On 01/16/2018 05:18 PM, Shaun Reitan wrote: > This patch replaces the patch I sent yesturday. This one fixes > a bug in my original code as well as corrects a few styling > issues. Hopfully this one comes out correct! Sorry for the > inconvienece. This paragraph belongs... > > When currently u

Re: [Qemu-devel] [PATCH] Add ability to provide ifname when using netdev bridge or tap helper

2018-01-17 Thread Philippe Mathieu-Daudé
On 01/17/2018 07:39 AM, Paolo Bonzini wrote: > On 17/01/2018 11:31, Daniel P. Berrange wrote: >> >> eg consider the user asks for a tap device called eth1. To the >> sysadmin the user's tap device now looks like a physical NIC. >> This can be even worse if the host does physical NIC hotplug, >> or

Re: [Qemu-devel] [PATCH] Add ability to provide ifname when using netdev bridge or tap helper

2018-01-17 Thread Daniel P. Berrange
On Wed, Jan 17, 2018 at 06:53:30PM +0800, Jason Wang wrote: > > > On 2018年01月17日 18:31, Daniel P. Berrange wrote: > > On Tue, Jan 16, 2018 at 03:18:24PM -0800, Shaun Reitan wrote: > > > This patch replaces the patch I sent yesturday. This one fixes > > > a bug in my original code as well as corre

Re: [Qemu-devel] [PATCH] Add ability to provide ifname when using netdev bridge or tap helper

2018-01-17 Thread Jason Wang
On 2018年01月17日 18:31, Daniel P. Berrange wrote: On Tue, Jan 16, 2018 at 03:18:24PM -0800, Shaun Reitan wrote: This patch replaces the patch I sent yesturday. This one fixes a bug in my original code as well as corrects a few styling issues. Hopfully this one comes out correct! Sorry for the i

Re: [Qemu-devel] [PATCH] Add ability to provide ifname when using netdev bridge or tap helper

2018-01-17 Thread Paolo Bonzini
On 17/01/2018 11:31, Daniel P. Berrange wrote: > > eg consider the user asks for a tap device called eth1. To the > sysadmin the user's tap device now looks like a physical NIC. > This can be even worse if the host does physical NIC hotplug, > or uses SRIOV. eg consider the host as eth0 -> eth7 f

Re: [Qemu-devel] [PATCH] Add ability to provide ifname when using netdev bridge or tap helper

2018-01-17 Thread Daniel P. Berrange
On Tue, Jan 16, 2018 at 03:18:24PM -0800, Shaun Reitan wrote: > This patch replaces the patch I sent yesturday. This one fixes > a bug in my original code as well as corrects a few styling > issues. Hopfully this one comes out correct! Sorry for the > inconvienece. > > When currently using -netd

Re: [Qemu-devel] [PATCH] Add ability to provide ifname when using netdev bridge or tap helper

2018-01-16 Thread Jason Wang
On 2018年01月17日 07:18, Shaun Reitan wrote: This patch replaces the patch I sent yesturday. This one fixes a bug in my original code as well as corrects a few styling issues. Hopfully this one comes out correct! Sorry for the inconvienece. When currently using -netdev bridge or -netdev tap wi

[Qemu-devel] [PATCH] Add ability to provide ifname when using netdev bridge or tap helper

2018-01-16 Thread Shaun Reitan
This patch replaces the patch I sent yesturday. This one fixes a bug in my original code as well as corrects a few styling issues. Hopfully this one comes out correct! Sorry for the inconvienece. When currently using -netdev bridge or -netdev tap with a helper you are unable to set an ifname. Th